From: Stephen Hemminger <shemminger@osdl.org>
To: "Eric Lemoine" <eric.lemoine@gmail.com>
Cc: "Jeff Garzik" <jgarzik@pobox.com>, netdev@vger.kernel.org
Subject: Re: [PATCH 10/10] chelesio: transmit locking (plus bug fix).
Date: Mon, 4 Dec 2006 09:58:28 -0800 [thread overview]
Message-ID: <20061204095828.0e50f359@freekitty> (raw)
In-Reply-To: <5cac192f0612030245j434db528sd7bc755408827cf7@mail.gmail.com>
On Sun, 3 Dec 2006 11:45:09 +0100
"Eric Lemoine" <eric.lemoine@gmail.com> wrote:
> Stephen,
>
> On 12/2/06, Stephen Hemminger <shemminger@osdl.org> wrote:
> > If transmit lock is contended on, then push return code back
> > and retry at higher level.
>
> Looking at qdisc_restart, it seems to me that the NETDEV_TX_LOCKED
> return code must only be used if the device features LLTX. With your
> patch, if q->lock is already grabbed, qdisc_restart is going to
> requeue skb without going through the collision section of
> qdisc_restart.
>
The Chelsio driver already sets LLTX (see drivers/net/chelsio/cxgb2.c)
prev parent reply other threads:[~2006-12-04 17:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-02 0:36 [PATCH 00/10] chelsio: 10G driver Stephen Hemminger
2006-12-02 0:36 ` [PATCH 01/10] chelsio: whitespace fixes Stephen Hemminger
2006-12-02 0:36 ` [PATCH 02/10] chelsio: use kzalloc Stephen Hemminger
2006-12-02 0:36 ` [PATCH 03/10] chelsio: remove unused mutex Stephen Hemminger
2006-12-02 0:36 ` [PATCH 05/10] chelsio: add 1G swcixw aupport Stephen Hemminger
2006-12-02 0:36 ` [PATCH 06/10] chelsio: cleanup pm3393 code Stephen Hemminger
2006-12-02 0:36 ` [PATCH 07/10] chelsio: use standard CRC routines Stephen Hemminger
2006-12-02 0:36 ` [PATCH 08/10] chelsio: add MSI support Stephen Hemminger
2006-12-02 0:36 ` [PATCH 09/10] chelsio: statistics improvement Stephen Hemminger
2006-12-02 0:36 ` [PATCH 10/10] chelesio: transmit locking (plus bug fix) Stephen Hemminger
2006-12-03 10:45 ` Eric Lemoine
2006-12-04 17:58 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061204095828.0e50f359@freekitty \
--to=shemminger@osdl.org \
--cc=eric.lemoine@gmail.com \
--cc=jgarzik@pobox.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.