From: Martin Schwidefsky <schwidefsky@de.ibm.com>
To: linux-kernel@vger.kernel.org, horst.hummel@de.ibm.com
Subject: [S390] return 'count' for successful execution of dasd_eer_enable.
Date: Mon, 4 Dec 2006 15:52:51 +0100 [thread overview]
Message-ID: <20061204145251.GM32059@skybase> (raw)
From: Horst Hummel <horst.hummel@de.ibm.com>
[S390] return 'count' for successful execution of dasd_eer_enable.
Currently the return value of 'dasd_eer_enable' is returned - even if the
function returned '0'. Now return 'count' for successful execution.
Signed-off-by: Horst Hummel <horst.hummel@de.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
---
drivers/s390/block/dasd_devmap.c | 9 +++++----
1 files changed, 5 insertions(+), 4 deletions(-)
diff -urpN linux-2.6/drivers/s390/block/dasd_devmap.c linux-2.6-patched/drivers/s390/block/dasd_devmap.c
--- linux-2.6/drivers/s390/block/dasd_devmap.c 2006-12-04 14:50:30.000000000 +0100
+++ linux-2.6-patched/drivers/s390/block/dasd_devmap.c 2006-12-04 14:50:44.000000000 +0100
@@ -877,12 +877,13 @@ dasd_eer_store(struct device *dev, struc
if (((endp + 1) < (buf + count)) || (val > 1))
return -EINVAL;
- rc = count;
- if (val)
+ if (val) {
rc = dasd_eer_enable(devmap->device);
- else
+ if (rc)
+ return rc;
+ } else
dasd_eer_disable(devmap->device);
- return rc;
+ return count;
}
static DEVICE_ATTR(eer_enabled, 0644, dasd_eer_show, dasd_eer_store);
reply other threads:[~2006-12-04 14:53 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061204145251.GM32059@skybase \
--to=schwidefsky@de.ibm.com \
--cc=horst.hummel@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.