From: Greg KH <gregkh@suse.de>
To: "Lu, Yinghai" <yinghai.lu@amd.com>
Cc: ebiederm@xmission.com,
USB development list <linux-usb-devel@lists.sourceforge.net>,
Stefan Reinauer <stepan@coresystems.de>,
Peter Stuge <stuge-linuxbios@cdy.org>,
linuxbios@linuxbios.org, linux-kernel@vger.kernel.org,
Andi Kleen <ak@suse.de>
Subject: Re: [RFC][PATCH 2/2] x86_64: earlyprintk usb debug device support.
Date: Mon, 4 Dec 2006 12:33:08 -0800 [thread overview]
Message-ID: <20061204203308.GA30307@suse.de> (raw)
In-Reply-To: <5986589C150B2F49A46483AC44C7BCA4907280@ssvlexmb2.amd.com>
On Mon, Dec 04, 2006 at 12:18:30PM -0800, Lu, Yinghai wrote:
> -----Original Message-----
> From: ebiederm@xmission.com [mailto:ebiederm@xmission.com]
>
> >arch/x86_64/kernel/early_printk.c | 574
> +++++++++++++++++++++++++++++++++++++
> > drivers/usb/host/ehci.h | 8 +
> > include/asm-x86_64/fixmap.h | 1
>
> Can you separate usbdebug handle out from early_printk?
Yeah, at least tear it out of x86-64, so those of us stuck on different
platforms can use this :)
Other than that minor issue, this looks great. I don't have a x86-64
box set up here at the moment, so I can't test it, but it looks
acceptable at first glance.
thanks,
greg k-h
next prev parent reply other threads:[~2006-12-04 20:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-04 20:18 [RFC][PATCH 2/2] x86_64: earlyprintk usb debug device support Lu, Yinghai
2006-12-04 20:33 ` Greg KH [this message]
2006-12-04 21:26 ` Eric W. Biederman
2006-12-05 0:45 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2006-12-09 1:20 Lu, Yinghai
2006-12-07 3:20 Lu, Yinghai
2006-12-09 1:17 ` Greg KH
2006-12-05 3:18 Lu, Yinghai
2006-12-04 20:52 Lu, Yinghai
2006-12-01 18:55 [LinuxBIOS] #57: libusb host program for PLX NET20DC debug device Lu, Yinghai
2006-12-01 19:19 ` Greg KH
2006-12-03 15:49 ` Eric W. Biederman
2006-12-04 5:09 ` [RFC][PATCH 0/2] x86_64 Early usb debug port support Eric W. Biederman
2006-12-04 5:13 ` [RFC][PATCH 1/2] x86_64: Preallocate the fixmap pud and pmd entries Eric W. Biederman
2006-12-04 5:18 ` [RFC][PATCH 2/2] x86_64: earlyprintk usb debug device support Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061204203308.GA30307@suse.de \
--to=gregkh@suse.de \
--cc=ak@suse.de \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb-devel@lists.sourceforge.net \
--cc=linuxbios@linuxbios.org \
--cc=stepan@coresystems.de \
--cc=stuge-linuxbios@cdy.org \
--cc=yinghai.lu@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.