From: Alan <alan@lxorguk.ukuu.org.uk>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org, jgarzik@pobox.com,
linux-ide@vger.kernel.org
Subject: Re: [PATCH] pata_it8213: Add new driver for the IT8213 card.
Date: Mon, 4 Dec 2006 21:55:58 +0000 [thread overview]
Message-ID: <20061204215558.63bc4e90@localhost.localdomain> (raw)
In-Reply-To: <20061204124344.a7c21221.akpm@osdl.org>
> Was the duplication of timings[] deliberate?
It's actually duplicated in all the PIIX/ICH-alike drivers. I could move
it in them all. Jeff - its copied from your piix driver - shall I move
them all ?
> diff -puN include/linux/pci_ids.h~pata_it8213-add-new-driver-for-the-it8213-card-tidy include/linux/pci_ids.h
> --- a/include/linux/pci_ids.h~pata_it8213-add-new-driver-for-the-it8213-card-tidy
> +++ a/include/linux/pci_ids.h
> @@ -1622,6 +1622,7 @@
> #define PCI_VENDOR_ID_ITE 0x1283
> #define PCI_DEVICE_ID_ITE_8211 0x8211
> #define PCI_DEVICE_ID_ITE_8212 0x8212
> +#define PCI_DEVICE_ID_ITE_8213 0x8213
Sorry about that one - your guess is 100% correct of course
next prev parent reply other threads:[~2006-12-04 22:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-04 16:49 [PATCH] pata_it8213: Add new driver for the IT8213 card Alan
2006-12-04 20:43 ` Andrew Morton
2006-12-04 21:55 ` Alan [this message]
2006-12-04 22:38 ` Jeff Garzik
2006-12-07 12:19 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061204215558.63bc4e90@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akpm@osdl.org \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.