All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Wong <normalperson@yhbt.net>
To: Sam Vilain <sam@vilain.net>
Cc: Junio C Hamano <junkio@cox.net>, git@vger.kernel.org
Subject: Re: [PATCH 1/4] git-svn: let libsvn_ls_fullurl return properties too
Date: Mon, 4 Dec 2006 17:04:28 -0800	[thread overview]
Message-ID: <20061205010428.GA26687@soma> (raw)
In-Reply-To: <7v3b7vnqtv.fsf@assigned-by-dhcp.cox.net>

Junio C Hamano <junkio@cox.net> wrote:
> Thanks.
> 
> Please CC people who are primarily working on the part of the
> system you are improving.  In the case of git-svn that would be
> Eric Wong.

Yes, CCs regarding git-svn would be much appreciated, thanks.

> As I almost never touch git-svn myself, I'll queue these four
> changes in 'pu' while waiting Ack from Eric on them.

Ack on what the patches do, but not as-is.

Please fix the coding style so that it's consistent with the rest of
git-svn:

a) indentation is done with hard tabs
b) no spaces around parentheses: "if ($foo) {" vs "if ( $foo ) {"

Also, adding tests would be helpful in helping me maintain it (I'm not
a regular svk user, so I don't want to break anything you've done down
the line).

Thanks.

-- 

  reply	other threads:[~2006-12-05  1:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-04  9:33 [PATCH 1/4] git-svn: let libsvn_ls_fullurl return properties too Sam Vilain
2006-12-05  0:12 ` Junio C Hamano
2006-12-05  1:04   ` Eric Wong [this message]
2006-12-05  1:10     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061205010428.GA26687@soma \
    --to=normalperson@yhbt.net \
    --cc=git@vger.kernel.org \
    --cc=junkio@cox.net \
    --cc=sam@vilain.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.