Re: [PATCH] PV framebuffer

["Daniel P. Berrange" <berrange@redhat.com>]

On Mon, Dec 04, 2006 at 08:29:25PM +0000, Daniel P. Berrange wrote:
> 
> On Fri, Dec 01, 2006 at 01:25:42PM +0000, Steven Smith wrote:
> > Applied.
> > 
> > Thanks,
> > 
> > Steven.
> 
> Looking at the patches applied for the PVFB code & config re-arrangement
> I think that VNC password handling for fullyvirt HVM guests has been
> broken

> The following hunk  against tools/python/xen/xm/create.py removes processing
> of the 'vncpassword' config parameter from the guest config files for HVM
> guests:
> 
> 
>   @@ -678,20 +690,13 @@ def configure_vifs(config_devs, vals):
>            config_devs.append(['device', config_vif])
>  
>  
>   -def configure_graphics(config_image, vals):
>   -    """Create the config for graphic consoles.
>   -    """
>   -    args = [ 'vnc', 'vncdisplay', 'vncconsole', 'vncunused',
>   -             'sdl', 'display', 'xauthority', 'vnclisten', 'vncpasswd']
>   -    for a in args:
>   -        if (vals.__dict__[a]):
>   -            config_image.append([a, vals.__dict__[a]])
>   -
>    def configure_hvm(config_image, vals):
>        """Create the config for HVM devices.
>        """
>        args = [ 'device_model', 'pae', 'vcpus', 'boot', 'fda', 'fdb',
>                 'localtime', 'serial', 'stdvga', 'isa', 'nographic', 'soundhw',
>   +             'vnc', 'vncdisplay', 'vncunused', 'vncconsole', 'vnclisten',
>   +             'sdl', 'display', 'xauthority',
>                 'acpi', 'apic', 'usb', 'usbdevice', 'keymap' ]
>        for a in args:
>            if a in vals.__dict__ and vals.__dict__[a] is not None:
> 
> 
> I've not been able to actually verify it since I don't currently have
> a working xen-unstable build, but I don't see how it can work without
> the 'vncpasswd' parameter included there in the args for configure_hvm.

Ignore me. I see there is special case code for vncpasswd parameter elsewhere
in the create.py file, which ensures its processed correctly, so there's no
bug here.  I had missed it because of a merge issue with my vncpassword
patches for the Paravirt FB.

Dan.
-- 
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=|