All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: "Horst H. von Brand" <vonbrand@inf.utfsm.cl>
Cc: Andrew Morton <akpm@osdl.org>, Jiri Kosina <jkosina@suse.cz>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] let WARN_ON() output the condition
Date: Wed, 6 Dec 2006 14:54:45 +0100	[thread overview]
Message-ID: <20061206135445.GA17224@elte.hu> (raw)
In-Reply-To: <200612061252.kB6CqRYP008046@laptop13.inf.utfsm.cl>


* Horst H. von Brand <vonbrand@inf.utfsm.cl> wrote:

> Why not just:
> 
>     WARN_ON(debug_locks_off())
> 
> here? Would give a more readable message too, IMHO.

debug_locks_off() has a side-effect, and in general we dont like to put 
stuff with side-effects witin WARN_ON().

	Ingo

  reply	other threads:[~2006-12-06 13:56 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-06  0:51 [PATCH] let WARN_ON() output the condition Jiri Kosina
2006-12-06  1:27 ` Andrew Morton
2006-12-06 12:52   ` Horst H. von Brand
2006-12-06 13:54     ` Ingo Molnar [this message]
2006-12-06 14:35       ` Jaswinder Singh
2006-12-06 15:08         ` Jiri Kosina
2006-12-06  8:37 ` Ingo Molnar
2006-12-06  8:47   ` Jiri Kosina
2006-12-06  8:54     ` Ingo Molnar
2006-12-06  9:04       ` Jiri Kosina
2006-12-06  9:07         ` Ingo Molnar
2006-12-06  9:11           ` Jiri Kosina
2006-12-06  9:27             ` Ingo Molnar
2006-12-06  9:14           ` Jan Engelhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061206135445.GA17224@elte.hu \
    --to=mingo@elte.hu \
    --cc=akpm@osdl.org \
    --cc=jkosina@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vonbrand@inf.utfsm.cl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.