From: David Brownell <david-b@pacbell.net>
To: linux-usb-devel@lists.sourceforge.net
Cc: linuxppc-dev@ozlabs.org, greg@kroah.com,
stern@rowland.harvard.edu, sl@bplan-gmbh.de
Subject: Re: [linux-usb-devel] [PATCH 1/2] Fixed compiled issue tu to new of_platform.h header
Date: Wed, 6 Dec 2006 17:19:59 -0800 [thread overview]
Message-ID: <200612061720.01082.david-b@pacbell.net> (raw)
In-Reply-To: <11642982461138-git-send-email-nd@bplan-gmbh.de>
On Thursday 23 November 2006 8:12 am, nd@bplan-gmbh.de wrote:
> drivers/usb/host/ohci-ppc-of.c | 285 ++++++++++++++++++++++++++++++++++++++++
You've split one "add new bus glue" patch into two ... please
do it the normal way, as one patch!
(Oh, I see you did that the next day. The next two comments
still apply.)
> + * Store this function in the HCD's struct pci_driver as probe().
You should remove irrelevant/ancient comments like this. Looks
like you cloned the PCI bus glue and didn't update key parts...
> + */
> +static int usb_hcd_ppc_of_probe(const struct hc_driver *driver,
> + struct of_device *dev, int is_bigendian)
I'm not sure why you didn't just have ohci_hcd_ppc_of_drv_probe()
do all this stuff; there's no point in splitting that code into
two chunks.
Likewise, ohci_hcd_ppc_of_drv_remove() shouldn't be split in two.
prev parent reply other threads:[~2006-12-07 1:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-23 16:11 [RFC] USB OHCI glue for PowerPC/Openfirmware nd
2006-11-23 16:12 ` [PATCH 1/2] Fixed compiled issue tu to new of_platform.h header nd
2006-11-23 16:12 ` [PATCH 2/2] USB OHCI OpenFirmware support nd
2006-11-24 8:57 ` [PATCH 1/2] Fixed compiled issue tu to new of_platform.h header Greg KH
2006-11-24 20:48 ` Benjamin Herrenschmidt
2006-11-24 21:06 ` Alan Stern
2006-11-24 21:19 ` Benjamin Herrenschmidt
2006-12-03 8:23 ` Sven Luther
2006-12-03 9:13 ` Nicolas DET
2006-12-03 14:57 ` Sven Luther
2006-12-07 1:19 ` David Brownell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200612061720.01082.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=greg@kroah.com \
--cc=linux-usb-devel@lists.sourceforge.net \
--cc=linuxppc-dev@ozlabs.org \
--cc=sl@bplan-gmbh.de \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.