From: Nathan Lynch <ntl@pobox.com>
To: Michael Ellerman <michael@ellerman.id.au>
Cc: linuxppc-dev@ozlabs.org, paulus@samba.org
Subject: Re: [PATCH 3/4] add rtas_service_present() helper
Date: Wed, 6 Dec 2006 21:25:23 -0600 [thread overview]
Message-ID: <20061207032523.GG18846@localdomain> (raw)
In-Reply-To: <1165459893.14780.0.camel@concordia.ozlabs.ibm.com>
Michael Ellerman wrote:
> On Wed, 2006-12-06 at 18:50 -0600, Nathan Lynch wrote:
> > To test for the existence of an RTAS function, we typically do:
> >
> > foo_token = rtas_token("foo");
> > if (foo_token == RTAS_UNKNOWN_SERVICE)
> > return;
> >
> > Add a rtas_service_present method, which provides a more conventional
> > boolean interface for testing the existence of an RTAS method.
>
>
> I like it a lot ..
>
> But should it be called rtas_token_present() ? :D
I considered that, but thought my name was a little more descriptive
-- a token is merely an integer value, but we're really interested in
whether the service named is available.
I don't really care that much either way, though :)
next prev parent reply other threads:[~2006-12-07 3:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-07 0:50 [PATCH 1/4] maple: match "pcie" name for CPC945 Nathan Lynch
2006-12-07 0:50 ` [PATCH 2/4] maple: select PPC_RTAS Nathan Lynch
2006-12-07 0:50 ` [PATCH 3/4] add rtas_service_present() helper Nathan Lynch
2006-12-07 0:50 ` [PATCH 4/4] maple: use RTAS for reboot and halt Nathan Lynch
2006-12-07 2:51 ` [PATCH 3/4] add rtas_service_present() helper Michael Ellerman
2006-12-07 3:25 ` Nathan Lynch [this message]
2006-12-07 21:05 ` Linas Vepstas
2006-12-07 3:20 ` [PATCH 1/4] maple: match "pcie" name for CPC945 Olof Johansson
2006-12-07 8:41 ` Segher Boessenkool
2006-12-07 8:30 ` Segher Boessenkool
2006-12-11 22:38 ` Nathan Lynch
2006-12-12 22:26 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061207032523.GG18846@localdomain \
--to=ntl@pobox.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=michael@ellerman.id.au \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.