From: Adrian Bunk <bunk@stusta.de>
To: Michael Chan <mchan@broadcom.com>
Cc: davem@davemloft.net, jgarzik@pobox.com, linux-kernel@vger.kernel.org
Subject: [2.6 patch] drivers/net/bnx2.c: add an error check
Date: Thu, 7 Dec 2006 12:34:33 +0100 [thread overview]
Message-ID: <20061207113433.GC8963@stusta.de> (raw)
This patch adds a missing error check spotted by the Coverity checker.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.19-rc6-mm2/drivers/net/bnx2.c.old 2006-12-06 13:32:51.000000000 +0100
+++ linux-2.6.19-rc6-mm2/drivers/net/bnx2.c 2006-12-06 13:33:34.000000000 +0100
@@ -2510,7 +2510,7 @@
if (CHIP_NUM(bp) == CHIP_NUM_5709) {
fw = &bnx2_cp_fw_09;
- load_cpu_fw(bp, &cpu_reg, fw);
+ rc = load_cpu_fw(bp, &cpu_reg, fw);
if (rc)
goto init_cpu_err;
}
next reply other threads:[~2006-12-07 11:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-07 11:34 Adrian Bunk [this message]
2006-12-07 11:47 ` [2.6 patch] drivers/net/bnx2.c: add an error check Jeff Garzik
2006-12-07 17:31 ` Michael Chan
2006-12-07 23:10 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061207113433.GC8963@stusta.de \
--to=bunk@stusta.de \
--cc=davem@davemloft.net \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mchan@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.