From: Alan <alan@lxorguk.ukuu.org.uk>
To: jgarzik@pobox.com, linux-ide@vger.kernel.org, akpm@osdl.org
Subject: [PATCH] libata: Incorrect timing computation for PIO5/6
Date: Thu, 7 Dec 2006 12:41:18 +0000 [thread overview]
Message-ID: <20061207124118.0feee6d9@localhost.localdomain> (raw)
The ata timing computation code makes some mistakes in PIO5/6 because a
check was not updated correctly when I put this support into the kernel.
Signed-off-by: Alan Cox <alan@redhat.com>
diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.19-rc6-mm1/drivers/ata/libata-core.c linux-2.6.19-rc6-mm1/drivers/ata/libata-core.c
--- linux.vanilla-2.6.19-rc6-mm1/drivers/ata/libata-core.c 2006-11-24 13:58:28.000000000 +0000
+++ linux-2.6.19-rc6-mm1/drivers/ata/libata-core.c 2006-12-07 10:28:21.229413880 +0000
@@ -2164,7 +2164,7 @@
* DMA cycle timing is slower/equal than the fastest PIO timing.
*/
- if (speed > XFER_PIO_4) {
+ if (speed > XFER_PIO_6) {
ata_timing_compute(adev, adev->pio_mode, &p, T, UT);
ata_timing_merge(&p, t, t, ATA_TIMING_ALL);
}
next reply other threads:[~2006-12-07 12:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-07 12:41 Alan [this message]
2006-12-07 12:39 ` [PATCH] libata: Incorrect timing computation for PIO5/6 Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061207124118.0feee6d9@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akpm@osdl.org \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.