All of lore.kernel.org
 help / color / mirror / Atom feed
From: Roy Marples <uberlord@gentoo.org>
To: netdev@vger.kernel.org
Cc: linville@tuxdriver.com
Subject: [PATCH] prism54: set carrier flags correctly
Date: Thu, 7 Dec 2006 15:47:05 +0000	[thread overview]
Message-ID: <200612071547.05987.uberlord@gentoo.org> (raw)

prism54 should set the carrier flags correctly when it thinks the link can be used.

Signed-off-by: Roy Marples <uberlord@gentoo.org>

--- a/drivers/net/wireless/prism54/isl_ioctl.c	2006-08-24 10:48:50.000000000 +0100
+++ b/drivers/net/wireless/prism54/isl_ioctl.c	2006-08-24 10:29:32.000000000 +0100
@@ -1573,8 +1573,11 @@
 		} else
 			send_simple_event(netdev_priv(ndev),
 					  "Link established");
-	} else
+		netif_carrier_on(ndev);
+	} else {
 		send_simple_event(netdev_priv(ndev), "Link lost");
+		netif_carrier_off(ndev);
+	}
 }
 
 /* Beacon/ProbeResp payload header */
--- a/drivers/net/wireless/prism54/islpci_dev.c	2006-08-24 10:48:50.000000000 +0100
+++ b/drivers/net/wireless/prism54/islpci_dev.c	2006-08-24 10:30:31.000000000 +0100
@@ -387,7 +387,9 @@
 	}
 
 	netif_start_queue(ndev);
-/*      netif_mark_up( ndev ); */
+
+	/* Turn off carrier unless we know we have associated */
+	netif_carrier_off(ndev);
 
 	return 0;
 }

                 reply	other threads:[~2006-12-07 15:47 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200612071547.05987.uberlord@gentoo.org \
    --to=uberlord@gentoo.org \
    --cc=linville@tuxdriver.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.