From: Ralf Baechle <ralf@linux-mips.org>
To: Vitaly Wool <vitalywool@gmail.com>
Cc: linux-mips@linux-mips.org
Subject: Re: [PATCH] add STB810 support (Philips PNX8550-based)
Date: Thu, 7 Dec 2006 15:48:30 +0000 [thread overview]
Message-ID: <20061207154830.GB4156@linux-mips.org> (raw)
In-Reply-To: <20061207182234.83212939.vitalywool@gmail.com>
On Thu, Dec 07, 2006 at 06:22:34PM +0300, Vitaly Wool wrote:
> Index: linux-mips.git/arch/mips/philips/pnx8550/stb810/Makefile
> ===================================================================
> --- /dev/null 1970-01-01 00:00:00.000000000 +0000
> +++ linux-mips.git/arch/mips/philips/pnx8550/stb810/Makefile 2006-12-07 18:21:04.000000000 +0300
> @@ -0,0 +1,4 @@
> +
> +# Makefile for the Philips STB810 Board.
> +
> +lib-y := prom_init.o board_setup.o irqmap.o
> Index: linux-mips.git/arch/mips/philips/pnx8550/stb810/board_setup.c
> ===================================================================
> --- /dev/null 1970-01-01 00:00:00.000000000 +0000
> +++ linux-mips.git/arch/mips/philips/pnx8550/stb810/board_setup.c 2006-12-07 18:21:04.000000000 +0300
> @@ -0,0 +1,56 @@
> +/*
> + * STB810 specific board startup routines.
> + *
> + * Based on the arch/mips/philips/pnx8550/jbs/board_setup.c
> + *
> + * Author: MontaVista Software, Inc.
> + * source@mvista.com
> + *
> + * Copyright 2005 MontaVista Software Inc.
> + *
> + * This program is free software; you can redistribute it and/or modify it
> + * under the terms of the GNU General Public License as published by the
> + * Free Software Foundation; either version 2 of the License, or (at your
> + * option) any later version.
> + */
> +
> +#include <linux/init.h>
> +#include <linux/sched.h>
> +#include <linux/ioport.h>
> +#include <linux/mm.h>
> +#include <linux/console.h>
> +#include <linux/mc146818rtc.h>
> +#include <linux/delay.h>
> +
> +#include <asm/cpu.h>
> +#include <asm/bootinfo.h>
> +#include <asm/irq.h>
> +#include <asm/mipsregs.h>
> +#include <asm/reboot.h>
> +#include <asm/pgtable.h>
> +
> +#include <glb.h>
> +
> +/* CP0 hazard avoidance. */
> +#define BARRIER __asm__ __volatile__(".set noreorder\n\t" \
> + "nop; nop; nop; nop; nop; nop;\n\t" \
> + ".set reorder\n\t")
> +
> +void __init board_setup(void)
> +{
> + unsigned long config0, configpr;
> +
> + config0 = read_c0_config();
> +
> + /* clear all three cache coherency fields */
> + config0 &= ~(0x7 | (7<<25) | (7<<28));
> + config0 |= (CONF_CM_DEFAULT | (CONF_CM_DEFAULT<<25) |
> + (CONF_CM_DEFAULT<<28));
> + write_c0_config(config0);
> + BARRIER;
> +
> + configpr = read_c0_config7();
> + configpr |= (1<<19); /* enable tlb */
> + write_c0_config7(configpr);
> + BARRIER;
> +}
You really need that hazard barrier?
Chances are you can get away without a hazard barrier I guess.
> Index: linux-mips.git/arch/mips/philips/pnx8550/stb810/irqmap.c
> ===================================================================
> --- /dev/null 1970-01-01 00:00:00.000000000 +0000
> +++ linux-mips.git/arch/mips/philips/pnx8550/stb810/irqmap.c 2006-12-07 18:21:04.000000000 +0300
> +char irq_tab_jbs[][5] __initdata = {
> + [8] = { -1, PNX8550_INT_PCI_INTA, 0xff, 0xff, 0xff},
> + [9] = { -1, PNX8550_INT_PCI_INTA, 0xff, 0xff, 0xff},
> + [10] = { -1, PNX8550_INT_PCI_INTA, 0xff, 0xff, 0xff},
Coding style, indent with tabs.
> Index: linux-mips.git/arch/mips/kernel/head.S
> ===================================================================
> --- linux-mips.git.orig/arch/mips/kernel/head.S 2006-12-07 18:20:47.000000000 +0300
> +++ linux-mips.git/arch/mips/kernel/head.S 2006-12-07 18:21:04.000000000 +0300
> @@ -138,7 +138,7 @@
> EXPORT(stext) # used for profiling
> EXPORT(_stext)
>
> -#if defined(CONFIG_QEMU) || defined(CONFIG_MIPS_SIM)
> +#if defined(CONFIG_QEMU) || defined(CONFIG_MIPS_SIM) || defined(CONFIG_PNX8550_STB810)
Your firmware is really so broken it needs this?
> Index: linux-mips.git/arch/mips/configs/pnx8550-stb810_defconfig
> ===================================================================
> --- /dev/null 1970-01-01 00:00:00.000000000 +0000
> +++ linux-mips.git/arch/mips/configs/pnx8550-stb810_defconfig 2006-12-07 18:21:04.000000000 +0300
> @@ -0,0 +1,1777 @@
> +#
> +# Automatically generated make config: don't edit
> +# Linux kernel version: 2.6.19-rc5
> +# Wed Nov 8 13:46:57 2006
> +#
> +CONFIG_ARM=y
LOL.
Doesn't look quite right. Let's see if you find out why ;-)
Ralf
next prev parent reply other threads:[~2006-12-07 15:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-07 15:22 [PATCH] add STB810 support (Philips PNX8550-based) Vitaly Wool
2006-12-07 15:46 ` Sergei Shtylyov
2006-12-07 15:48 ` Ralf Baechle [this message]
2006-12-07 20:43 ` Vitaly Wool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061207154830.GB4156@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=linux-mips@linux-mips.org \
--cc=vitalywool@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.