From: Stephen Hemminger <shemminger@osdl.org>
To: Divy Le Ray <divy@chelsio.com>
Cc: Jeff Garzik <jeff@garzik.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/10] cxgb3: Chelsio T3 1G/10G ethernet device driver
Date: Fri, 8 Dec 2006 10:35:57 -0800 [thread overview]
Message-ID: <20061208103557.38c3dd9b@localhost> (raw)
In-Reply-To: <4578DB2F.4010204@chelsio.com>
Minor style stuff (that can be fixed later).
1) /* C style comments */ are preferred over // C++ style
2) Please use C99 style structure initializers especially for OS
interface structures like ops for MII.
next prev parent reply other threads:[~2006-12-08 18:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-08 3:25 [PATCH 0/10] cxgb3: Chelsio T3 1G/10G ethernet device driver Divy Le Ray
2006-12-08 18:35 ` Stephen Hemminger [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-12-22 7:19 Divy Le Ray
2006-12-14 5:40 Divy Le Ray
2006-12-15 16:57 ` Steve Wise
2006-12-15 17:06 ` Jeff Garzik
2006-12-15 17:15 ` Steve Wise
2006-12-04 19:43 Divy Le Ray
2006-11-17 20:22 Divy Le Ray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061208103557.38c3dd9b@localhost \
--to=shemminger@osdl.org \
--cc=divy@chelsio.com \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.