From: Olaf Hering <olaf@aepfle.de>
To: Al Viro <viro@ftp.linux.org.uk>
Cc: Linus Torvalds <torvalds@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] more work_struct mess
Date: Sat, 9 Dec 2006 12:25:10 +0100 (MET) [thread overview]
Message-ID: <20061209112515.GA1923@aepfle.de> (raw)
In-Reply-To: <20061208091649.GL4587@ftp.linux.org.uk>
On Fri, Dec 08, Al Viro wrote:
> +++ b/sound/oss/dmasound/tas3001c.c
> @@ -823,7 +823,7 @@ tas3001c_init(struct i2c_client *client)
> tas3001c_write_biquad_shadow(self, i, j,
> &tas3001c_eq_unity);
>
> - INIT_WORK(&device_change, tas3001c_device_change_handler, self);
> + INIT_WORK(&self->change, tas3001c_device_change_handler);
> +++ b/sound/oss/dmasound/tas3004.c
> @@ -1112,7 +1111,7 @@ tas3004_init(struct i2c_client *client)
> tas3004_write_register(self, TAS3004_REG_MCR2, &mcr2, WRITE_SHADOW);
> tas3004_write_register(self, TAS3004_REG_DRC, drce_init, WRITE_SHADOW);
>
> - INIT_WORK(&device_change, tas3004_device_change_handler, self);
> + INIT_WORK(&self->change, tas3004_device_change_handler);
This is not enough to get it going:
error: 'INIT_WORK' undeclared (first use in this function)
next prev parent reply other threads:[~2006-12-09 11:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-08 9:16 [PATCH] more work_struct mess Al Viro
2006-12-09 11:25 ` Olaf Hering [this message]
2006-12-09 18:04 ` Al Viro
2006-12-09 20:26 ` Olaf Hering
2006-12-11 0:48 ` Benjamin Herrenschmidt
2006-12-18 0:35 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061209112515.GA1923@aepfle.de \
--to=olaf@aepfle.de \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.