All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@mandriva.com>
To: dccp@vger.kernel.org
Subject: Re: [PATCH] BUG-FIX - conversion errors
Date: Sat, 09 Dec 2006 11:26:16 +0000	[thread overview]
Message-ID: <20061209112616.GA17909@mandriva.com> (raw)
In-Reply-To: <200612081532.21104@strip-the-willow>

On Sat, Dec 09, 2006 at 04:57:12PM +1300, Ian McDonald wrote:
> On 12/9/06, Gerrit Renker <gerrit@erg.abdn.ac.uk> wrote:
> >[CCID3]: BUG-FIX - conversion errors
> >-                       u16 w_init = min(    4 * hctx->ccid3hctx_s,
> >-                                        max(2 * hctx->ccid3hctx_s, 4380));
> >+                       __u64 w_init = min(    4 * hctx->ccid3hctx_s,
> >+                                          max(2 * hctx->ccid3hctx_s, 
> >4380));
> 
> This has broken this code on line 478 of ccid3.c:
> 			ccid3_pr_debug("%s(%p), s=%u, w_init=%u, "
> 				       "R_sample=%ldus, X=%u\n", 
> 				       dccp_role(sk),
> 				       sk, hctx->ccid3hctx_s, w_init, 
> 				       r_sample,
> 				       (unsigned)(hctx->ccid3hctx_x >> 6));
> 
> 
> If I change the line to this it works for me:
> 			ccid3_pr_debug("%s(%p), s=%u, w_init=%llu, "

Thanks Ian, applied this fix.

- Arnaldo
- 

  parent reply	other threads:[~2006-12-09 11:26 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-08 15:32 [PATCH] BUG-FIX - conversion errors Gerrit Renker
2006-12-08 17:19 ` Ian McDonald
2006-12-09  3:57 ` Ian McDonald
2006-12-09 11:26 ` Arnaldo Carvalho de Melo [this message]
2006-12-11  7:23 ` Gerrit Renker
2006-12-11  8:52 ` Ian McDonald
2006-12-11  9:03 ` Gerrit Renker
2006-12-11  9:53 ` Arnaldo Carvalho de Melo
2006-12-11 10:31 ` Gerrit Renker
2006-12-17 21:55 ` Eddie Kohler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061209112616.GA17909@mandriva.com \
    --to=acme@mandriva.com \
    --cc=dccp@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.