Re: [PATCH] ieee80211softmac: Fix mutex_lock at exit of ieee80211_softmac_get_genie

[Michael Buesch <mb@bu3sch.de>]

On Sunday 10 December 2006 18:44, Johannes Berg wrote:
> On Sun, 2006-12-10 at 18:27 +0100, Ulrich Kunitz wrote:
> > ieee80211softmac_wx_get_genie locks the associnfo mutex at
> > function exit. This patch fixes it. The patch is against Linus'
> > tree (commit af1713e0).
> 
> Looks good, I wonder how this slipped in.

Nobody calls this function, as it's rather useless. ;)

> Acked-by: Johannes Berg <johannes@sipsolutions.net>
> 
> > Signed-off-by: Ulrich Kunitz <kune@deine-taler.de>
> > ---
> >  net/ieee80211/softmac/ieee80211softmac_wx.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/net/ieee80211/softmac/ieee80211softmac_wx.c b/net/ieee80211/softmac/ieee80211softmac_wx.c
> > index 480d72c..fa2f7da 100644
> > --- a/net/ieee80211/softmac/ieee80211softmac_wx.c
> > +++ b/net/ieee80211/softmac/ieee80211softmac_wx.c
> > @@ -463,7 +463,7 @@ ieee80211softmac_wx_get_genie(struct net
> >  			err = -E2BIG;
> >  	}
> >  	spin_unlock_irqrestore(&mac->lock, flags);
> > -	mutex_lock(&mac->associnfo.mutex);
> > +	mutex_unlock(&mac->associnfo.mutex);
> >  
> >  	return err;
> >  }
> 

-- 
Greetings Michael.