* [lm-sensors] [PATCH] Make lm70_remove a __devexit function
@ 2006-12-10 19:21 ` Ralf Baechle
0 siblings, 0 replies; 4+ messages in thread
From: Ralf Baechle @ 2006-12-10 19:21 UTC (permalink / raw)
To: Andrew Morton, linux-kernel, lm-sensors
Saves a few bytes on the module.
Signed-off-by: Ralf Baechle <ralf at linux-mips.org>
diff --git a/drivers/hwmon/lm70.c b/drivers/hwmon/lm70.c
index 6ba8473..7eaae38 100644
--- a/drivers/hwmon/lm70.c
+++ b/drivers/hwmon/lm70.c
@@ -126,7 +126,7 @@ out_dev_reg_failed:
return status;
}
-static int __exit lm70_remove(struct spi_device *spi)
+static int __devexit lm70_remove(struct spi_device *spi)
{
struct lm70 *p_lm70 = dev_get_drvdata(&spi->dev);
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] Make lm70_remove a __devexit function
@ 2006-12-10 19:21 ` Ralf Baechle
0 siblings, 0 replies; 4+ messages in thread
From: Ralf Baechle @ 2006-12-10 19:21 UTC (permalink / raw)
To: Andrew Morton, linux-kernel, lm-sensors
Saves a few bytes on the module.
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
diff --git a/drivers/hwmon/lm70.c b/drivers/hwmon/lm70.c
index 6ba8473..7eaae38 100644
--- a/drivers/hwmon/lm70.c
+++ b/drivers/hwmon/lm70.c
@@ -126,7 +126,7 @@ out_dev_reg_failed:
return status;
}
-static int __exit lm70_remove(struct spi_device *spi)
+static int __devexit lm70_remove(struct spi_device *spi)
{
struct lm70 *p_lm70 = dev_get_drvdata(&spi->dev);
^ permalink raw reply related [flat|nested] 4+ messages in thread* [lm-sensors] [PATCH] Make lm70_remove a __devexit function
2006-12-10 19:21 ` Ralf Baechle
@ 2006-12-17 19:16 ` Jean Delvare
-1 siblings, 0 replies; 4+ messages in thread
From: Jean Delvare @ 2006-12-17 19:16 UTC (permalink / raw)
To: Ralf Baechle; +Cc: Andrew Morton, linux-kernel, lm-sensors
Hi Ralf,
On Sun, 10 Dec 2006 19:21:51 +0000, Ralf Baechle wrote:
> Saves a few bytes on the module.
>
> Signed-off-by: Ralf Baechle <ralf at linux-mips.org>
>
> diff --git a/drivers/hwmon/lm70.c b/drivers/hwmon/lm70.c
> index 6ba8473..7eaae38 100644
> --- a/drivers/hwmon/lm70.c
> +++ b/drivers/hwmon/lm70.c
> @@ -126,7 +126,7 @@ out_dev_reg_failed:
> return status;
> }
>
> -static int __exit lm70_remove(struct spi_device *spi)
> +static int __devexit lm70_remove(struct spi_device *spi)
> {
> struct lm70 *p_lm70 = dev_get_drvdata(&spi->dev);
>
You're not actually saving memory with this change, as __devexit is
resolved to either __exit (i.e. nothing changes) or nothing (i.e. the
code is now always compiled in.) This is a bugfix though as currently
the code may be striped away while the driver still holds a pointer to
it.
Good catch, applied (with a different header comment), thanks.
--
Jean Delvare
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [lm-sensors] [PATCH] Make lm70_remove a __devexit function
@ 2006-12-17 19:16 ` Jean Delvare
0 siblings, 0 replies; 4+ messages in thread
From: Jean Delvare @ 2006-12-17 19:16 UTC (permalink / raw)
To: Ralf Baechle; +Cc: Andrew Morton, linux-kernel, lm-sensors
Hi Ralf,
On Sun, 10 Dec 2006 19:21:51 +0000, Ralf Baechle wrote:
> Saves a few bytes on the module.
>
> Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
>
> diff --git a/drivers/hwmon/lm70.c b/drivers/hwmon/lm70.c
> index 6ba8473..7eaae38 100644
> --- a/drivers/hwmon/lm70.c
> +++ b/drivers/hwmon/lm70.c
> @@ -126,7 +126,7 @@ out_dev_reg_failed:
> return status;
> }
>
> -static int __exit lm70_remove(struct spi_device *spi)
> +static int __devexit lm70_remove(struct spi_device *spi)
> {
> struct lm70 *p_lm70 = dev_get_drvdata(&spi->dev);
>
You're not actually saving memory with this change, as __devexit is
resolved to either __exit (i.e. nothing changes) or nothing (i.e. the
code is now always compiled in.) This is a bugfix though as currently
the code may be striped away while the driver still holds a pointer to
it.
Good catch, applied (with a different header comment), thanks.
--
Jean Delvare
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2006-12-17 19:16 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-12-10 19:21 [lm-sensors] [PATCH] Make lm70_remove a __devexit function Ralf Baechle
2006-12-10 19:21 ` Ralf Baechle
2006-12-17 19:16 ` [lm-sensors] " Jean Delvare
2006-12-17 19:16 ` Jean Delvare
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.