From: Adrian Bunk <bunk@stusta.de>
To: Jay Vosburgh <fubar@us.ibm.com>
Cc: Jeff Garzik <jeff@garzik.org>,
ctindel@users.sourceforge.net,
bonding-devel@lists.sourceforge.net, netdev@vger.kernel.org
Subject: [2.6 patch] bonding.h: "extern inline" -> "static inline"
Date: Tue, 12 Dec 2006 17:24:39 +0100 [thread overview]
Message-ID: <20061212162439.GX28443@stusta.de> (raw)
"extern inline" generates a warning with -Wmissing-prototypes and I'm
currently working on getting the kernel cleaned up for adding this to
the CFLAGS since it will help us to avoid a nasty class of runtime
errors.
If there are places that really need a forced inline, __always_inline
would be the correct solution.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
drivers/net/bonding/bonding.h | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
--- linux-2.6.19-mm1/drivers/net/bonding/bonding.h.old 2006-12-12 15:57:43.000000000 +0100
+++ linux-2.6.19-mm1/drivers/net/bonding/bonding.h 2006-12-12 15:58:17.000000000 +0100
@@ -237,12 +237,13 @@
#define BOND_ARP_VALIDATE_ALL (BOND_ARP_VALIDATE_ACTIVE | \
BOND_ARP_VALIDATE_BACKUP)
-extern inline int slave_do_arp_validate(struct bonding *bond, struct slave *slave)
+static inline int slave_do_arp_validate(struct bonding *bond,
+ struct slave *slave)
{
return bond->params.arp_validate & (1 << slave->state);
}
-extern inline u32 slave_last_rx(struct bonding *bond, struct slave *slave)
+static inline u32 slave_last_rx(struct bonding *bond, struct slave *slave)
{
if (slave_do_arp_validate(bond, slave))
return slave->last_arp_rx;
next reply other threads:[~2006-12-12 16:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-12 16:24 Adrian Bunk [this message]
2007-01-19 3:07 ` [2.6 patch] bonding.h: "extern inline" -> "static inline" Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061212162439.GX28443@stusta.de \
--to=bunk@stusta.de \
--cc=bonding-devel@lists.sourceforge.net \
--cc=ctindel@users.sourceforge.net \
--cc=fubar@us.ibm.com \
--cc=jeff@garzik.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.