From: Ingo Molnar <mingo@elte.hu>
To: Francois Romieu <romieu@fr.zoreil.com>
Cc: Jeff Garzik <jeff@garzik.org>, Linus Torvalds <torvalds@osdl.org>,
Andrew Morton <akpm@osdl.org>,
"David S. Miller" <davem@davemloft.net>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org
Subject: Re: [patch] net, 8139too.c: fix netpoll deadlock
Date: Wed, 13 Dec 2006 02:12:31 +0100 [thread overview]
Message-ID: <20061213011231.GA6361@elte.hu> (raw)
In-Reply-To: <20061212214939.GA470@electric-eye.fr.zoreil.com>
* Francois Romieu <romieu@fr.zoreil.com> wrote:
> > (I'll queue it, if Linus doesn't pick it up; please CC me in the
> > future)
>
> I have lived with the "NAPI ->poll() handler runs in BH irq enabled
> context" rule for years. Is it definitely false/dead ?
>
> If so at least 8139cp needs the same fix.
hm, this isnt really about NAPI polling, but about the
netconsole/netpoll/netdump poll_controller() handler.
with netconsole, printk can be called from IRQ context (and is
frequently from IRQ context during bootup or module initialization), so
a BH rule isnt enough for them.
Ingo
next prev parent reply other threads:[~2006-12-13 1:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-12 10:16 [patch] netpoll: fix netpoll lockups Ingo Molnar
2006-12-12 12:49 ` [patch] net, 8139too.c: fix netpoll deadlock Ingo Molnar
2006-12-12 13:28 ` Jeff Garzik
2006-12-12 21:49 ` Francois Romieu
2006-12-13 1:12 ` Ingo Molnar [this message]
2007-02-14 2:30 ` Atsushi Nemoto
2007-02-16 4:33 ` Atsushi Nemoto
2006-12-12 16:13 ` [patch] netpoll: fix netpoll lockups Linus Torvalds
2006-12-12 16:20 ` [patch] netpoll: fix netpoll lockup Ingo Molnar
2006-12-12 21:00 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061213011231.GA6361@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@osdl.org \
--cc=davem@davemloft.net \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
--cc=tglx@linutronix.de \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.