From: Alan <alan@lxorguk.ukuu.org.uk>
To: Chuck Ebbert <76306.1226@compuserve.com>
Cc: Kasper Sandberg <lkml@metanurb.dk>,
David Howells <dhowells@redhat.com>,
Andrew Morton <akpm@osdl.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
ak@muc.de, vojtech@suse.cz
Subject: Re: BUG? atleast >=2.6.19-rc5, x86 chroot on x86_64
Date: Wed, 13 Dec 2006 11:08:47 +0000 [thread overview]
Message-ID: <20061213110847.2b6b25db@localhost.localdomain> (raw)
In-Reply-To: <200612130253_MC3-1-D4E3-471@compuserve.com>
On Wed, 13 Dec 2006 02:50:01 -0500
Chuck Ebbert <76306.1226@compuserve.com> wrote:
> In-Reply-To: <1165984783.23819.7.camel@localhost>
>
> On Wed, 13 Dec 2006 05:39:43 +0100, Kasper Sandberg wrote:
>
> > do you think it may be a bug in the kernel? the stuff with wine that
> > gets thrown in the kernel messages?
>
> Let's just say the behavior has changed. It now returns
> -EINVAL instead of -ENOTTY when the msdos IOCTLs fail.
For an unknown ioctl the correct return is -ENOTTY. For an invalid ioctl
(known but wrong parameters) it may be -EINVAL.
> Anyway, here is a much simpler patch that restores the previous
> behavior (but leaves the message.) However if you aren't having
> any problems now other than the messages maybe there's no real
> problem after all?
As far as I can see from a quick review the code should return -ENOTTY
in this situation not -EINVAL, for all unhandled ioctls.
Alan
next prev parent reply other threads:[~2006-12-13 11:04 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-13 7:50 BUG? atleast >=2.6.19-rc5, x86 chroot on x86_64 Chuck Ebbert
2006-12-13 8:05 ` Kasper Sandberg
2006-12-13 11:08 ` Alan [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-12-11 8:27 Chuck Ebbert
2006-12-13 4:39 ` Kasper Sandberg
2006-12-06 2:31 Chuck Ebbert
2006-12-06 12:58 ` Kasper Sandberg
2006-12-06 13:08 ` David Howells
2006-12-06 16:06 ` Kasper Sandberg
2006-12-06 16:48 ` David Howells
2006-12-06 20:05 ` Kasper Sandberg
2006-12-06 21:29 ` Andi Kleen
2006-12-06 22:19 ` Kasper Sandberg
2006-12-05 20:32 Chuck Ebbert
2006-12-05 22:11 ` David Howells
2006-12-05 9:33 Chuck Ebbert
2006-12-05 14:19 ` David Howells
2006-12-06 0:11 ` Kasper Sandberg
2006-11-22 14:29 Kasper Sandberg
2006-11-22 23:25 ` Andrew Morton
2006-11-26 13:47 ` Kasper Sandberg
2006-12-05 2:36 ` Kasper Sandberg
2006-12-05 2:59 ` Kasper Sandberg
2006-12-05 3:20 ` Andrew Morton
2006-12-05 14:17 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061213110847.2b6b25db@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=76306.1226@compuserve.com \
--cc=ak@muc.de \
--cc=akpm@osdl.org \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkml@metanurb.dk \
--cc=vojtech@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.