From: Alan <alan@lxorguk.ukuu.org.uk>
To: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: akpm@osdl.org, bzolnier@gmail.com, linux-ide@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.19-rc1] Toshiba TC86C001 IDE driver
Date: Wed, 13 Dec 2006 14:53:25 +0000 [thread overview]
Message-ID: <20061213145325.41fc4300@localhost.localdomain> (raw)
In-Reply-To: <45800B4D.8000906@ru.mvista.com>
> >>+static int tc86c001_busproc(ide_drive_t *drive, int state)
> >>+{
>
> > Waste of space having a busproc routine. The maintainer removed all the
> > usable hotplug support from old IDE so this might as well be dropped.
>
> Don't know what you mean, ioctl is still there...
You can turn the bus on and off but there is no ability to actually swap
drives except in RHEL4 and 2.4.x-ac kernels. Hence "waste of space"
> > "Close but no cookie": please fix the PCI quirk to match the current -mm
> > behaviour with the ATA resource tree. Otherwise - nice driver.
>
> Ugh, I should've expected some backstab from -mm tree...
If it is native only then there are no problems with the quirk
Acked-by: Alan Cox <alan@redhat.com>
next prev parent reply other threads:[~2006-12-13 14:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-12 22:48 [PATCH 2.6.19-rc1] Toshiba TC86C001 IDE driver Sergei Shtylyov
2006-12-12 22:57 ` Sergei Shtylyov
2006-12-12 23:00 ` Randy Dunlap
2006-12-12 23:07 ` Sergei Shtylyov
2006-12-12 23:12 ` Randy Dunlap
2006-12-12 23:41 ` Alan
2006-12-13 1:09 ` Bartlomiej Zolnierkiewicz
2006-12-13 11:32 ` Alan
2006-12-13 14:01 ` Bartlomiej Zolnierkiewicz
2006-12-13 14:16 ` Alan
2006-12-13 14:19 ` Bartlomiej Zolnierkiewicz
2006-12-13 14:16 ` Sergei Shtylyov
2006-12-13 14:53 ` Alan [this message]
2006-12-13 0:40 ` Alan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061213145325.41fc4300@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akpm@osdl.org \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.