From: Olof Johansson <olof@lixom.net>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org, linux-pci@atrey.karlin.mff.cuni.cz,
Mackerras <paulus@samba.org>,
Paul
Subject: Re: [PATCH 6/9] MPIC MSI allocator
Date: Wed, 13 Dec 2006 18:09:21 -0600 [thread overview]
Message-ID: <20061213180921.487b1cea@pb15> (raw)
In-Reply-To: <1166052344.11914.233.camel@localhost.localdomain>
On Thu, 14 Dec 2006 10:25:44 +1100 Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
> This code in MPIC currently is only ever used on U3/U4 and so that code
> reserves IRQs we know are used for U3/U4 internal IRQs and not available
> for HT interrupts (or MSIs). The code, then, does a second pass also
> exclusing all IRQs for all devices in the device-tree.
>
> This is a "hack" that works until device-trees provide the right
> property we have defined for mpic to indicate what range of irqs is to
> be used for MSIs.
So make the platform register the range of (possibly) usable MSI
addresses instead of adding a nasty hack like that to the mpic driver.
Adding numeric constants like that (completely without comments as to
where they came from) in a function called
mpic_msi_auto_reserve_hwirqs() is just too ugly.
-Olof
next prev parent reply other threads:[~2006-12-14 0:10 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-13 10:39 [PATCH 0/9] Powerpc MSI Implementation (.. again) Michael Ellerman
2006-12-13 10:39 ` [PATCH 1/9] Add #defines for Hypertransport MSI fields Michael Ellerman
2006-12-13 10:39 ` [PATCH 2/9] Rip out the existing powerpc msi stubs Michael Ellerman
2006-12-13 10:39 ` [PATCH 3/9] Powerpc MSI implementation Michael Ellerman
2006-12-13 10:39 ` [PATCH 4/9] Enable MSI on Powerpc Michael Ellerman
2006-12-13 10:39 ` [PATCH 5/9] RTAS MSI implementation Michael Ellerman
2006-12-13 10:40 ` [PATCH 6/9] MPIC MSI allocator Michael Ellerman
2006-12-13 18:23 ` Olof Johansson
2006-12-13 23:25 ` Benjamin Herrenschmidt
2006-12-14 0:09 ` Olof Johansson [this message]
2006-12-14 0:32 ` Benjamin Herrenschmidt
2006-12-14 0:59 ` Michael Ellerman
2006-12-14 1:02 ` Benjamin Herrenschmidt
2006-12-14 1:06 ` Michael Ellerman
2006-12-14 14:46 ` Segher Boessenkool
2006-12-14 19:44 ` Benjamin Herrenschmidt
2006-12-15 1:47 ` Segher Boessenkool
2006-12-15 1:51 ` Michael Ellerman
2006-12-15 2:28 ` Benjamin Herrenschmidt
2006-12-15 2:58 ` Segher Boessenkool
2006-12-15 6:42 ` Olof Johansson
2006-12-14 1:06 ` Olof Johansson
2006-12-14 0:34 ` Michael Ellerman
2006-12-13 10:40 ` [PATCH 7/9] MPIC MSI backend Michael Ellerman
2006-12-13 10:40 ` [PATCH 8/9] Activate MSI on Powerpc Michael Ellerman
2006-12-13 10:40 ` [PATCH 9/9] Enable MSI mappings for MPIC Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061213180921.487b1cea@pb15 \
--to=olof@lixom.net \
--cc=benh@kernel.crashing.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.