From: Shawn Pearce <spearce@spearce.org>
To: Junio C Hamano <junio@hera.kernel.org>
Cc: Johannes.Schindelin@gmx.de, git@vger.kernel.org
Subject: Re: [PATCH 1/1] Bypass expensive content comparsion during rename detection
Date: Thu, 14 Dec 2006 07:13:36 -0500 [thread overview]
Message-ID: <20061214121336.GN1747@spearce.org> (raw)
In-Reply-To: <200612141126.kBEBQme7021704@hera.kernel.org>
Junio C Hamano <junio@hera.kernel.org> wrote:
> estimate_similarity() is called after it has determined that one
> and two do not match exactly, and it relies on populate_filespec
> with at least size-only has been called on them so that it can
> reject filepair with vastly different sizes, still without
> looking at (thus without loading) the contents.
*ouch* That hurts. OK, it makes a lot of sense, but its crazy.
About as crazy as the comment I put in my revised patch... ;-)
--
next prev parent reply other threads:[~2006-12-14 12:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-14 11:26 [PATCH 1/1] Bypass expensive content comparsion during rename detection Junio C Hamano
2006-12-14 12:13 ` Shawn Pearce [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-12-14 10:07 Shawn O. Pearce
2006-12-14 10:53 ` Johannes Schindelin
2006-12-14 11:08 ` Shawn Pearce
2006-12-14 11:13 ` Shawn Pearce
2006-12-14 11:18 ` Johannes Schindelin
2006-12-14 11:50 ` Shawn Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061214121336.GN1747@spearce.org \
--to=spearce@spearce.org \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=junio@hera.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.