Re: [PATCH] yet another package check

["Christoph Egger" <Christoph.Egger@amd.com>]

Why do you write non-portable shell scripts?

Some time ago, I made these portable:

check_brctl
check_iproute
check_libvncserver
check_python
check_sdl
check_zlib_devel
check_zlib_lib

For now, the non-portable scripts are:

check_crypto_lib
check_openssl_devel
check_python_devel
check_udev
check_x11_devel

Can you make them portable (again), please?



On Thursday 14 December 2006 15:06, you wrote:
> As before, the file added to tools/check/ must be given exec permission.
>
> Signed-off-by: Jan Beulich <jbeulich@novell.com>
>
> Index: 2006-12-11/tools/Makefile
> ===================================================================
> --- 2006-12-11.orig/tools/Makefile	2006-12-04 08:49:57.000000000 +0100
> +++ 2006-12-11/tools/Makefile	2006-12-14 14:25:02.000000000 +0100
> @@ -36,7 +36,7 @@ all: check
>  	$(MAKE) ioemu
>
>  .PHONY: install
> -install: check
> +install: check_install
>  	@set -e; for subdir in $(SUBDIRS-y); do \
>  		$(MAKE) -C $$subdir $@; \
>  	done
> @@ -58,6 +58,10 @@ distclean: clean
>  check:
>  	$(MAKE) -C check
>
> +.PHONY: check_install
> +check_install: check
> +	$(MAKE) -C check install
> +
>  .PHONY: check_clean
>  check_clean:
>  	$(MAKE) -C check clean
> Index: 2006-12-11/tools/check/check_python_xml
> ===================================================================
> --- /dev/null	1970-01-01 00:00:00.000000000 +0000
> +++ 2006-12-11/tools/check/check_python_xml	2006-12-14 14:05:30.000000000
> +0100 @@ -0,0 +1,16 @@
> +#!/bin/bash
> +# CHECK-INSTALL
> +
> +function error {
> +    echo
> +    echo "  *** Check for python-xml package FAILED"
> +    exit 1
> +}
> +
> +python -c '
> +import os.path, sys
> +for p in sys.path:
> +	if os.path.exists(p + "/xml/dom/minidom.py"):
> +		sys.exit(0)
> +sys.exit(1)
> +' || error
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel