All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Ishizaki Kou <kou.ishizaki@toshiba.co.jp>
Cc: linuxppc-dev@ozlabs.org, paulus@samba.org
Subject: Re: [PATCH 7/19] powerpc: hypervisor call numbers for Celleb
Date: Thu, 14 Dec 2006 18:32:35 +0100	[thread overview]
Message-ID: <20061214173235.GA6048@lst.de> (raw)
In-Reply-To: <200612140230.kBE2UT9R014367@toshiba.co.jp>

On Thu, Dec 14, 2006 at 11:30:28AM +0900, Ishizaki Kou wrote:

> +
> +#ifdef	__ASSEMBLY__
> +#define	__BEAT_ADD_VENDOR_ID(__x, __v)	((__v)<<60|(__x))
> +#elif defined(__powerpc64__)
> +#define	__BEAT_ADD_VENDOR_ID(__x, __v)	((unsigned long)(__v)<<60|(__x))
> +#else
> +#define	__BEAT_ADD_VENDOR_ID(__x, __v)	((unsigned long long)(__v)<<60|(__x))
> +#endif

__powerpc64__ is always set for ppc64 compiles.

> +#define HV_allocate_memory (0)
> +#define HV_construct_virtual_address_space (2)

isn't HV_foo a little too generic?  Also no need for the braces around
the actual hvall numbers.

  reply	other threads:[~2006-12-14 17:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-14  2:30 [PATCH 7/19] powerpc: hypervisor call numbers for Celleb Ishizaki Kou
2006-12-14 17:32 ` Christoph Hellwig [this message]
2006-12-20  8:31   ` Ishizaki Kou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061214173235.GA6048@lst.de \
    --to=hch@lst.de \
    --cc=kou.ishizaki@toshiba.co.jp \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.