From: Michael Buesch <mb@bu3sch.de>
To: Jiri Benc <jbenc@suse.cz>
Cc: bcm43xx-dev@lists.berlios.de, linville@tuxdriver.com,
netdev@vger.kernel.org
Subject: Re: [PATCH 1/2] d80211: Turn PHYmode list from an array into a linked list
Date: Fri, 15 Dec 2006 14:54:55 +0100 [thread overview]
Message-ID: <200612151454.55508.mb@bu3sch.de> (raw)
In-Reply-To: <20061215144859.49a9c8f3@griffin.suse.cz>
On Friday 15 December 2006 14:48, Jiri Benc wrote:
> On Thu, 14 Dec 2006 19:20:11 +0100, Michael Buesch wrote:
> > This turns the PHY-modes list into a linked list.
> > The advantage is that drivers can add modes dynamically, as they probe
> > them and don't have to settle to a given arraysize at the beginning
> > of probing.
>
> ACK.
Thanks. Will submit fixes for the other drivers, too.
> > @@ -198,8 +200,7 @@ static int ieee80211_ioctl_scan(struct n
> > param->u.scan.last_rx = local->scan.rx_packets;
> > local->scan.rx_packets = -1;
> > }
> > - param->u.scan.channel = local->hw.modes[local->scan.mode_idx].
> > - channels[local->scan.chan_idx].chan;
> > + param->u.scan.channel =
> > local->scan.mode->channels[local->scan.chan_idx].chan;
> >
> > return 0;
> > }
>
> The patch is malformed. Fixed and applied to my tree.
I'm sorry. Forgot to remove the "wrap at ~80chars option in my mailer.
Can you also apply the bcm43xx fix for this to your tree?
I think that should be easiest and prevent long-living breakage.
--
Greetings Michael.
next prev parent reply other threads:[~2006-12-15 13:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-14 18:20 [PATCH 1/2] d80211: Turn PHYmode list from an array into a linked list Michael Buesch
2006-12-15 13:48 ` Jiri Benc
2006-12-15 13:54 ` Michael Buesch [this message]
[not found] ` <200612151454.55508.mb-fseUSCV1ubazQB+pC5nmwQ@public.gmane.org>
2006-12-15 14:06 ` Jiri Benc
[not found] ` <20061215150655.50a728c4-IhiK2ZEFs2oCVLCxKZUutA@public.gmane.org>
2006-12-15 14:33 ` Michael Buesch
2006-12-15 15:37 ` Michael Buesch
2006-12-16 6:40 ` Michael Wu
2000-01-01 0:23 ` Michael Buesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200612151454.55508.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=bcm43xx-dev@lists.berlios.de \
--cc=jbenc@suse.cz \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.