[XENOPROFILE] Xenoprof passive profiling broken under cs 13062

["Ray Bryant" <raybry@mpdtxmail.amd.com>]

Renato,

If one creates an HVM domain (say domain 1) and then does

echo 1 > /dev/oprofile/passive_domains

one then gets the following on the Xen serial console:

(XEN) xenoprof.c:143:d0 xenoprof/x86 with autotranslated mode enabledisn't 
supported yet
(XEN) xenoprof.c:143:d0 xenoprof/x86 with autotranslated mode enabledisn't 
supported yet
(XEN) xenoprof.c:143:d0 xenoprof/x86 with autotranslated mode enabledisn't 
supported yet
(XEN) xenoprof.c:143:d0 xenoprof/x86 with autotranslated mode enabledisn't 
supported yet
(XEN) xenoprof.c:143:d0 xenoprof/x86 with autotranslated mode enabledisn't 
supported yet
(XEN) xenoprof.c:143:d0 xenoprof/x86 with autotranslated mode enabledisn't 
supported yet
(XEN) xenoprof.c:143:d0 xenoprof/x86 with autotranslated mode enabledisn't 
supported yet
(XEN) xenoprof.c:143:d0 xenoprof/x86 with autotranslated mode enabledisn't 
supported yet
(XEN) xenoprof.c:143:d0 xenoprof/x86 with autotranslated mode enabledisn't 
supported yet
----------- [cut here ] --------- [please bite here ] ---------
Kernel BUG at drivers/xen/xenoprof/xenoprofile.c:429
invalid opcode: 0000 [1] SMP
CPU 1
Modules linked in: xt_physdev iptable_filter ip_tables x_tables tun bridge 
usbmouse usbhid ide_cd cdrom floppy snd_atiixd
Pid: 5313, comm: bash Not tainted 2.6.16.33-xen #2
RIP: e030:[<ffffffff802806b6>] <ffffffff802806b6>{xenoprof_set_passive+190}
RSP: e02b:ffff880014ccfe88  EFLAGS: 00010292
RAX: 00000000f000ff53 RBX: 0000000000000000 RCX: ffffc20000940000
RDX: ffff88000138a160 RSI: 0000000000000000 RDI: ffffffff80353b90
RBP: 0000000000000000 R08: ffff880014ccfe08 R09: ffffffffffffffff
R10: 0000000000007ff0 R11: ffff880017c6fa80 R12: 0000000000000000
R13: 0000000000000000 R14: 0000000000000001 R15: 0000000000000000
FS:  00002b05deb40f60(0000) GS:ffffffff803c0080(0000) knlGS:0000000000000000
CS:  e033 DS: 0000 ES: 0000
Process bash (pid: 5313, threadinfo ffff880014cce000, task ffff88001fdeb820)
Stack: ffffffff8048c200 ffffffff803824c0 0000000000000001 ffffffff8048c200
       0000000000000002 ffff880014ccff50 0000000000000001 ffffffff8027de5c
       ffff8800189b1002 0000000000000001
Call Trace: <ffffffff8027de5c>{oprofile_set_passive+63}
       <ffffffff8027f9a7>{pdomain_write+291} <ffffffff8017a023>{vfs_write+212}
       <ffffffff8017a180>{sys_write+69} <ffffffff8010b382>{system_call+134}
       <ffffffff8010b2fc>{system_call+0}

Code: 0f 0b 68 22 48 32 80 c2 ad 01 89 c2 4c 89 e0 41 ff c5 48 c1
RIP <ffffffff802806b6>{xenoprof_set_passive+190} RSP <ffff880014ccfe88>

This for a 64 bit hypervisor and a 32 bit guest (although the above is all 
dom0 code related to mapping the xenoprof buffer, so I doubt the bittedness 
of the guest makes much difference); both AMD V and VT have the same problem.

I've tried this on change sets 12548, 13008 and 13062 (latest as of this
afternoon).   So this particular problem has been around for a bit.

Any ideas as to what went wrong here?

Thanks,
-- 
Ray Bryant
AMD Performance Labs                   Austin, Tx
512-602-0038 (o)                 512-507-7807 (c)