From: Adrian Bunk <bunk@stusta.de>
To: Andrew Morton <akpm@osdl.org>, Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: linux-kernel@vger.kernel.org, B.Zolnierkiewicz@elka.pw.edu.pl,
linux-ide@vger.kernel.org
Subject: [-mm patch] drivers/ide/pci/tc86c001.c: make a function static
Date: Sat, 16 Dec 2006 14:56:50 +0100 [thread overview]
Message-ID: <20061216135650.GA3388@stusta.de> (raw)
In-Reply-To: <20061214225913.3338f677.akpm@osdl.org>
On Thu, Dec 14, 2006 at 10:59:13PM -0800, Andrew Morton wrote:
>...
> Changes since 2.6.19-mm1:
>...
> +toshiba-tc86c001-ide-driver-take-2.patch
>...
> Misc.
>...
This patch makes the needlessly global init_hwif_tc86c001() static.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
BTW:
I'm not sure whether it'd be a good idea to include such a driver for
the legacy IDE subsystem without a libata based driver for the same
hardware.
--- linux-2.6.20-rc1-mm1/drivers/ide/pci/tc86c001.c.old 2006-12-15 21:58:44.000000000 +0100
+++ linux-2.6.20-rc1-mm1/drivers/ide/pci/tc86c001.c 2006-12-15 21:58:54.000000000 +0100
@@ -204,7 +204,7 @@
return 0;
}
-void __devinit init_hwif_tc86c001(ide_hwif_t *hwif)
+static void __devinit init_hwif_tc86c001(ide_hwif_t *hwif)
{
unsigned long sc_base = pci_resource_start(hwif->pci_dev, 5);
u16 scr1 = hwif->INW(sc_base + 0x00);;
next prev parent reply other threads:[~2006-12-16 13:56 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-15 6:59 2.6.20-rc1-mm1 Andrew Morton
2006-12-15 6:59 ` BUG: NMI Watchdog detected LOCKUP (was: 2.6.20-rc1-mm1) Tilman Schmidt
2006-12-19 18:52 ` Thomas Gleixner
2006-12-19 19:56 ` [patch] hrtimers: add state tracking, fix Ingo Molnar
2006-12-20 1:38 ` Tilman Schmidt
2006-12-20 20:05 ` Tilman Schmidt
2006-12-15 14:46 ` OOPS: deref 0x14 at pdc_port_start+0x82 [Was: 2.6.20-rc1-mm1] Jiri Slaby
2006-12-15 19:24 ` Andrew Morton
2006-12-15 22:49 ` Jiri Slaby
2006-12-15 20:39 ` 2.6.20-rc1-mm1 Damien Wyart
2006-12-15 21:01 ` 2.6.20-rc1-mm1 Andrew Morton
2006-12-17 11:07 ` 2.6.20-rc1-mm1 Damien Wyart
2006-12-18 8:03 ` 2.6.20-rc1-mm1 Laurent Riffard
2006-12-18 18:35 ` 2.6.20-rc1-mm1 Damien Wyart
2006-12-19 23:29 ` 2.6.20-rc1-mm1 Luben Tuikov
2006-12-18 7:44 ` 2.6.20-rc1-mm1 Jens Axboe
2006-12-15 23:26 ` WARNING (1) at .../arch/i386/mm/highmem.c:49 [Was: 2.6.20-rc1-mm1] Jiri Slaby
2006-12-16 0:16 ` Andrew Morton
2006-12-16 0:04 ` 2.6.20-rc1-mm1: unused sysrq_timer_list_show() Adrian Bunk
2006-12-16 7:56 ` [patch] debugging feature: SysRq-Q to print timers Ingo Molnar
2006-12-18 23:31 ` Andrew Morton
2006-12-18 23:45 ` Dave Jones
2006-12-19 0:00 ` Andrew Morton
2006-12-19 12:01 ` Ingo Molnar
2006-12-16 12:37 ` (Cross) compiling fails on first try (was Re: 2.6.20-rc1-mm1) Jan Dittmer
2006-12-16 13:56 ` Adrian Bunk [this message]
2006-12-16 14:18 ` [-mm patch] drivers/ide/pci/tc86c001.c: make a function static Alan
2006-12-17 18:08 ` Sergei Shtylyov
2006-12-17 20:52 ` Sergei Shtylyov
2006-12-16 13:56 ` [-mm patch] make uio_irq_handler() static Adrian Bunk
2006-12-20 6:09 ` Greg KH
2006-12-16 13:56 ` [-mm patch] drivers/video/{s3fb,svgalib}.c: possible cleanups Adrian Bunk
2006-12-16 17:39 ` Randy Dunlap
2006-12-16 18:16 ` Ondrej Zajicek
2006-12-16 13:57 ` [-mm patch] mm/vmscan.c: make a function static Adrian Bunk
2006-12-16 19:30 ` [-mm patch] noinitramfs cleanup Frederik Deweerdt
2006-12-18 13:38 ` [-mm patch] kill pxa2xx Kconfig warning Frederik Deweerdt
2006-12-18 20:06 ` 2.6.20-rc1-mm1 Bartlomiej Zolnierkiewicz
2006-12-19 0:29 ` 2.6.20-rc1-mm1 Randy Dunlap
2006-12-19 0:42 ` 2.6.20-rc1-mm1 Andrew Morton
2006-12-21 18:35 ` [-mm patch] ptrace: make {put,get}reg work again for gs and fs Frederik Deweerdt
2006-12-21 19:22 ` Jeremy Fitzhardinge
2006-12-21 20:53 ` Frederik Deweerdt
2006-12-21 21:59 ` Frederik Deweerdt
2006-12-22 2:00 ` Jeremy Fitzhardinge
[not found] ` <20061221181108.6cede9ba.akpm@osdl.org>
2006-12-22 6:06 ` Frederik Deweerdt
[not found] ` <20061221225414.de09c7df.akpm@osdl.org>
2006-12-22 7:00 ` Jeremy Fitzhardinge
2006-12-22 8:05 ` Frederik Deweerdt
2006-12-22 6:52 ` Jeremy Fitzhardinge
2006-12-22 6:55 ` Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061216135650.GA3388@stusta.de \
--to=bunk@stusta.de \
--cc=B.Zolnierkiewicz@elka.pw.edu.pl \
--cc=akpm@osdl.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.