From: Russell King <rmk+lkml@arm.linux.org.uk>
To: "Robert P. J. Day" <rpjday@mindspring.com>
Cc: Linux kernel mailing list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Remove logically superfluous comparisons from Kconfig files.
Date: Mon, 18 Dec 2006 10:26:53 +0000 [thread overview]
Message-ID: <20061218102653.GA23947@flint.arm.linux.org.uk> (raw)
In-Reply-To: <Pine.LNX.4.64.0612180509010.22527@localhost.localdomain>
On Mon, Dec 18, 2006 at 05:14:01AM -0500, Robert P. J. Day wrote:
> Remove Kconfig comparisons of the form FUBAR || FUBAR=n, since they
> appear to be superfluous.
config FOO
tristate 'foo'
depends on BAR || BAR=n
is not superfluous. The allowed states for FOO with the above construct
are (assuming modules are enabled):
BAR FOO
Y Y,M,N
M M,N
N Y,M,N
Also, you create some constructs such as:
depends on && PCI
which is obviously wrong.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of:
next prev parent reply other threads:[~2006-12-18 10:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-18 10:14 [PATCH] Remove logically superfluous comparisons from Kconfig files Robert P. J. Day
2006-12-18 10:26 ` Russell King [this message]
2006-12-18 10:28 ` Robert P. J. Day
2006-12-27 13:03 ` Horst H. von Brand
2006-12-27 23:38 ` Robert P. J. Day
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061218102653.GA23947@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=rpjday@mindspring.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.