From: Ingo Molnar <mingo@elte.hu>
To: Matthew Wilcox <matthew@wil.cx>
Cc: Jarek Poplawski <jarkao2@o2.pl>,
linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>
Subject: Re: [patch] lock debugging: fix DEBUG_LOCKS_WARN_ON() & debug_locks_silent
Date: Tue, 19 Dec 2006 10:44:32 +0100 [thread overview]
Message-ID: <20061219094432.GA1699@elte.hu> (raw)
In-Reply-To: <20061219094017.GM21070@parisc-linux.org>
* Matthew Wilcox <matthew@wil.cx> wrote:
> On Tue, Dec 19, 2006 at 10:31:35AM +0100, Ingo Molnar wrote:
> >
> > * Jarek Poplawski <jarkao2@o2.pl> wrote:
> >
> > > > if (unlikely(c)) { \
> > > > - if (debug_locks_silent || debug_locks_off()) \
> > > > + if (!debug_locks_silent && debug_locks_off()) \
> >
> > btw., updated patch is below - the right order is to first do
> > debug_locks_off(), then debug_locks_silent.
>
> Then how does one re-enable lock debugging after running the locking
> testsuite?
see the lib/locking-selftest.c:locking_selftest() function, if all
testcases pass then it re-enables lock debugging. If a testcase turns
off lock debugging because it triggers a bug (as many of them
legitimately do), then reset_locks()->lockdep_reset() will set
debug_locks back to 1.
Ingo
prev parent reply other threads:[~2006-12-19 9:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-16 6:26 Doubled stack dumps during locking testsuite Matthew Wilcox
2006-12-16 8:04 ` [patch] lock debugging: fix DEBUG_LOCKS_WARN_ON() & debug_locks_silent Ingo Molnar
2006-12-19 8:43 ` Jarek Poplawski
2006-12-19 8:51 ` Matthew Wilcox
2006-12-19 9:05 ` Jarek Poplawski
2006-12-19 9:31 ` Ingo Molnar
2006-12-19 9:40 ` Matthew Wilcox
2006-12-19 9:44 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061219094432.GA1699@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@osdl.org \
--cc=jarkao2@o2.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.