All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Wilcox <matthew@wil.cx>
To: Sergio Paracuellos <sparacuellos@lock-linux.com>
Cc: linux-fsdevel@vger.kernel.org
Subject: Re: inode i_blksize problem
Date: Wed, 20 Dec 2006 06:39:59 -0700	[thread overview]
Message-ID: <20061220133959.GP21070@parisc-linux.org> (raw)
In-Reply-To: <1166617616.27420.11.camel@localhost.localdomain>

On Wed, Dec 20, 2006 at 01:26:56PM +0100, Sergio Paracuellos wrote:
> I am trying to compile a module for kernel 2.6.18-1 that uses the 'inode
> struct' but the compiler tell me inode struct hasn't a member called
> "i_blksize". I don't have that problem in kernel 2.6.16. What happend
> with i_blksize?

git-log reveals:

commit ba52de123d454b57369f291348266d86f4b35070
Author: Theodore Ts'o <tytso@mit.edu>
Date:   Wed Sep 27 01:50:49 2006 -0700

    [PATCH] inode-diet: Eliminate i_blksize from the inode structure
    
    This eliminates the i_blksize field from struct inode.  Filesystems that wan
t
    to provide a per-inode st_blksize can do so by providing their own getattr
    routine instead of using the generic_fillattr() function.
    
    Note that some filesystems were providing pretty much random (and incorrect)
    values for i_blksize.
    
    [bunk@stusta.de: cleanup]
    [akpm@osdl.org: generic_fillattr() fix]
    Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
    Signed-off-by: Adrian Bunk <bunk@stusta.de>
    Signed-off-by: Andrew Morton <akpm@osdl.org>
    Signed-off-by: Linus Torvalds <torvalds@osdl.org>

So, it's gone.  I'd just delete that line from your sources if I were you.
By the way, what kind of module is this?  Whatever it's doing looks
pretty dodgy to me.

      reply	other threads:[~2006-12-20 13:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-20 12:26 inode i_blksize problem Sergio Paracuellos
2006-12-20 13:39 ` Matthew Wilcox [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061220133959.GP21070@parisc-linux.org \
    --to=matthew@wil.cx \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=sparacuellos@lock-linux.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.