All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vivek Goyal <vgoyal@in.ibm.com>
To: Jean Delvare <khali@linux-fr.org>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>,
	Andi Kleen <ak@suse.de>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: Patch "i386: Relocatable kernel support" causes instant reboot
Date: Thu, 21 Dec 2006 09:10:29 +0530	[thread overview]
Message-ID: <20061221034029.GD30299@in.ibm.com> (raw)
In-Reply-To: <20061221145401.07bfe408.khali@linux-fr.org>

On Thu, Dec 21, 2006 at 02:54:01PM +0100, Jean Delvare wrote:
> On Thu, 21 Dec 2006 03:32:33 -0700, Eric W. Biederman wrote:
> > Ok.  There is almost enough for inference but here is a patch of stops
> > for setup.S let's see if one of those will stop the reboots.
> >
> > I have a strong feeling that we are going to find a tool chain issue,
> > but I'd like to find where we ware having problems before we declare
> > that to be the case.
> > (...)
> > diff --git a/arch/i386/boot/setup.S b/arch/i386/boot/setup.S
> > index 06edf1c..2868020 100644
> > --- a/arch/i386/boot/setup.S
> > +++ b/arch/i386/boot/setup.S
> > @@ -795,6 +795,7 @@ a20_done:
> >
> >  #endif /* CONFIG_X86_VOYAGER */
> >  # set up gdt and idt and 32bit start address
> > +10: jmp	10b
> 
> Locked here, removed.
> 
> Out of curiosity, what does the "b" stand for?
> 

I think one can have multiple labels named as 10: so we need to specify
which one do you want to jump to. Either forward one (f) or backward
one (b).
 
[..]
> 
> Locked here, removed.
> 
> >  	# Jump to the 32bit entry point
> >  	jmpl *(code32_start - start + (DELTA_INITSEG << 4))(%esi)
> >  .code16
> 
> Which brought me to the original situation, where unsurprisingly the
> reboot happened. So the problem is located after label 14. Does it help?
>

Ok. so indirect jump seems to be having problem. On my machine disassembly
of setup.o show following.

ff a6 14 02 00 00       jmp    *0x214(%esi)

This seems to be fine as 0x14 is the offset of code32_start, and 
((DELTA_INITSEG) << 4) is 0x200. How does it look like on your machine?

Thanks
Vivek
  

  parent reply	other threads:[~2006-12-21 14:10 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20061220141808.e4b8c0ea.khali@linux-fr.org>
2006-12-20 14:00 ` Patch "i386: Relocatable kernel support" causes instant reboot Eric W. Biederman
     [not found]   ` <20061220214340.f6b037b1.khali@linux-fr.org>
2006-12-20 22:22     ` Eric W. Biederman
     [not found]       ` <20061221101240.f7e8f107.khali@linux-fr.org>
     [not found]         ` <20061221102232.5a10bece.khali@linux-fr.org>
2006-12-21 10:32           ` Eric W. Biederman
2006-12-21  1:08             ` Vivek Goyal
2006-12-21 12:32               ` Eric W. Biederman
2006-12-21  2:26                 ` Vivek Goyal
2006-12-21  3:54                   ` Vivek Goyal
2006-12-21 13:13               ` Jean Delvare
2006-12-21  3:13                 ` Vivek Goyal
2006-12-21 13:59                   ` Jean Delvare
2006-12-21 17:45                     ` Alexander van Heukelum
2006-12-21 20:44                       ` Vivek Goyal
2006-12-22  8:08                         ` Jean Delvare
2006-12-22 10:40                           ` Vivek Goyal
2006-12-22 22:22                             ` Jean Delvare
2006-12-22 22:37                               ` Eric W. Biederman
2006-12-26 12:43                             ` Segher Boessenkool
2006-12-26 14:03                               ` Jean Delvare
2006-12-27  4:00                               ` Vivek Goyal
2006-12-27  4:25                                 ` Segher Boessenkool
2007-01-01 21:39                             ` Jean Delvare
2007-01-02  6:11                               ` Vivek Goyal
2007-01-02  9:29                                 ` Jean Delvare
2007-01-02 13:44                                   ` Segher Boessenkool
     [not found]             ` <20061221145401.07bfe408.khali@linux-fr.org>
2006-12-21  3:40               ` Vivek Goyal [this message]
2006-12-21 14:22                 ` Jean Delvare
2006-12-21  4:41     ` Vivek Goyal
2006-12-21  8:55       ` Jean Delvare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061221034029.GD30299@in.ibm.com \
    --to=vgoyal@in.ibm.com \
    --cc=ak@suse.de \
    --cc=ebiederm@xmission.com \
    --cc=khali@linux-fr.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.