All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mathieu Desnoyers <compudj@krystal.dyndns.org>
To: linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>,
	Ingo Molnar <mingo@redhat.com>,
	Greg Kroah-Hartman <gregkh@suse.de>,
	Christoph Hellwig <hch@infradead.org>
Cc: Douglas Niehaus <niehaus@eecs.ku.edu>,
	"Martin J. Bligh" <mbligh@mbligh.org>,
	ltt-dev@shafik.org, Thomas Gleixner <tglx@linutronix.de>,
	systemtap@sources.redhat.com
Subject: [PATCH] atomic.h : x86_64 atomic64_add_return
Date: Thu, 21 Dec 2006 14:42:08 -0500	[thread overview]
Message-ID: <20061221194208.GA25249@Krystal> (raw)
In-Reply-To: <20061221001405.GO28643@Krystal>

atomic64_add_return fix for volatile removal

atomic64_add_return should follow the change done to atomic.h following the
removal of "volatile" in the atomic_t type, just like atomic_add_return.

It applies cleanly on top of my "atomic.h : x86_64" patch posted in this
thread.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>

diff --git a/include/asm-x86_64/atomic.h b/include/asm-x86_64/atomic.h
index e9922ae..3e9f838 100644
--- a/include/asm-x86_64/atomic.h
+++ b/include/asm-x86_64/atomic.h
@@ -375,8 +375,8 @@ static __inline__ long atomic64_add_retu
 	long __i = i;
 	__asm__ __volatile__(
 		LOCK_PREFIX "xaddq %0, %1;"
-		:"=r"(i)
-		:"m"(v->counter), "0"(i));
+		:"+r" (i), "+m" (v->counter)
+		: : "memory");
 	return i + __i;
 }
-- 
OpenPGP public key:              http://krystal.dyndns.org:8080/key/compudj.gpg
Key fingerprint:     8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68 

      reply	other threads:[~2006-12-21 19:42 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-21  0:03 [PATCH 0/9] atomic.h : standardising atomic primitives Mathieu Desnoyers
2006-12-21  0:06 ` [PATCH 1/9] atomic.h : alpha architecture Mathieu Desnoyers
2006-12-21  0:07 ` [PATCH 2/9] atomic.h : generic atomic_long Mathieu Desnoyers
2006-12-21  0:08 ` [PATCH 3/9] atomic.h : i386 "64 bits" ready fix Mathieu Desnoyers
2006-12-21  0:09 ` [PATCH 4/9] atomic.h : ia64 Mathieu Desnoyers
2006-12-21  0:10 ` [PATCH 5/9] atomic.h : standardising atomic primitives Mathieu Desnoyers
2006-12-21  0:10 ` [PATCH 6/9] atomic.h : parisc Mathieu Desnoyers
2006-12-21  0:12 ` [PATCH 7/9] atomic.h : powerpc Mathieu Desnoyers
2006-12-21  0:12   ` Mathieu Desnoyers
2006-12-21  3:15   ` Benjamin Herrenschmidt
2006-12-21  3:15     ` Benjamin Herrenschmidt
2006-12-21  3:29     ` Mathieu Desnoyers
2006-12-21  3:29       ` Mathieu Desnoyers
2006-12-21  0:12 ` [PATCH 8/9] atomic.h : sparc Mathieu Desnoyers
2006-12-21  0:14 ` [PATCH 9/9] atomic.h : x86_64 Mathieu Desnoyers
2006-12-21 19:42   ` Mathieu Desnoyers [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061221194208.GA25249@Krystal \
    --to=compudj@krystal.dyndns.org \
    --cc=akpm@osdl.org \
    --cc=gregkh@suse.de \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ltt-dev@shafik.org \
    --cc=mbligh@mbligh.org \
    --cc=mingo@redhat.com \
    --cc=niehaus@eecs.ku.edu \
    --cc=systemtap@sources.redhat.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.