From: Tony Lindgren <tony@atomide.com>
To: Dirk Behme <dirk.behme@googlemail.com>
Cc: linux-omap-open-source@linux.omap.com
Subject: Re: [PATCH] ARM: OMAP: Fix ethernet IRQF_TRIGGER flag for apollon
Date: Thu, 21 Dec 2006 13:57:55 -0800 [thread overview]
Message-ID: <20061221215755.GE10399@atomide.com> (raw)
In-Reply-To: <458A5728.2060905@gmail.com>
* Dirk Behme <dirk.behme@googlemail.com> [061221 01:43]:
>
> ARM: OMAP: Fix ethernet IRQF_TRIGGER flag for apollon
>
> As reported by Kyungmin Park, ethernet IRQF_TRIGGER flag for
> apollon has to be IRQF_TRIGGER_RISING instead of
> IRQF_TRIGGER_HIGH.
>
> Signed-off-by: Dirk Behme <dirk.behme_at_gmail.com>
>
> Index: linux-osk/drivers/net/smc91x.h
> ===================================================================
> --- linux-osk.orig/drivers/net/smc91x.h
> +++ linux-osk/drivers/net/smc91x.h
> @@ -198,7 +198,7 @@ SMC_outw(u16 val, void __iomem *ioaddr,
> ? IRQF_TRIGGER_RISING : IRQF_TRIGGER_FALLING)
> #else
> #define SMC_IRQ_FLAGS (machine_is_omap_apollon() \
> - ? IRQF_TRIGGER_HIGH : IRQF_TRIGGER_LOW)
> + ? IRQF_TRIGGER_RISING : IRQF_TRIGGER_LOW)
> #endif
>
> #elif defined(CONFIG_SH_SH4202_MICRODEV)
>
AFAIK we _should_ be able to use level GPIO interrupts on all omap2
systems. I wonder why that does not work on apollon? Is there some
difference in hardware, or maybe some GPIO lines don't support level
interrupts on omap2?
Tony
next prev parent reply other threads:[~2006-12-21 21:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-21 9:43 [PATCH] ARM: OMAP: Fix ethernet IRQF_TRIGGER flag for apollon Dirk Behme
2006-12-21 21:57 ` Tony Lindgren [this message]
2006-12-21 22:19 ` Syed Mohammed, Khasim
2006-12-21 22:24 ` Woodruff, Richard
2006-12-21 23:29 ` Tony Lindgren
2006-12-22 21:08 ` Tony Lindgren
-- strict thread matches above, loose matches on Subject: below --
2006-12-22 5:57 Kyungmin Park
2006-12-22 20:26 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061221215755.GE10399@atomide.com \
--to=tony@atomide.com \
--cc=dirk.behme@googlemail.com \
--cc=linux-omap-open-source@linux.omap.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.