All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shawn Pearce <spearce@spearce.org>
To: Jakub Narebski <jnareb@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 3/3] Don't crash during repack of a reflog with pruned commits.
Date: Thu, 21 Dec 2006 20:23:44 -0500	[thread overview]
Message-ID: <20061222012344.GD14773@spearce.org> (raw)
In-Reply-To: <emfbk4$f45$1@sea.gmane.org>

Jakub Narebski <jnareb@gmail.com> wrote:
> I still think it is a good idea to allow user (experienced user)
> to set to not consider reflog for saving. Especially that there
> exist repositories which have reflogs with long pruned commits,
> and it would be nice to preserve the reflog info, even if some of
> information is not available.

In my humble opinion there is *no* value in a reflog whose commits
are "corrupt" (due to missing commit object or missing tree/blob
it references) as you cannot get that commit back.  And its hard
to get any other data from it.

My local git.git repository got killed during a repack because
I was missing 1 blob (an old version of builtin-blame.c) from
Junio's pu branch.  Apparently I had a reflog on that tracking
branch which went back pretty far and although the commits in that
log were still available, the blob wasn't.

-- 
Shawn.

  reply	other threads:[~2006-12-22  1:24 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <be6b1443171482e1930bd7744a0218db0c03d611.1166748450.git.spearce@spearce.org>
2006-12-22  0:48 ` [PATCH 2/3] Introduce a global level warn() function Shawn O. Pearce
2006-12-22  0:49 ` [PATCH 3/3] Don't crash during repack of a reflog with pruned commits Shawn O. Pearce
2006-12-22  0:52   ` Junio C Hamano
2006-12-22  1:00     ` Shawn Pearce
2006-12-22  1:18       ` Jakub Narebski
2006-12-22  1:23         ` Shawn Pearce [this message]
2006-12-22  0:56   ` Shawn Pearce
2006-12-22  8:16     ` Junio C Hamano
2006-12-22  8:22       ` Shawn Pearce

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061222012344.GD14773@spearce.org \
    --to=spearce@spearce.org \
    --cc=git@vger.kernel.org \
    --cc=jnareb@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.