From: Alexander Litvinov <litvinov2004@gmail.com>
To: Junio C Hamano <junkio@cox.net>
Cc: "Johannes Schindelin" <Johannes.Schindelin@gmx.de>,
"Uwe Kleine-König" <zeisberg@informatik.uni-freiburg.de>,
git@vger.kernel.org
Subject: Re: specify charset for commits
Date: Fri, 22 Dec 2006 01:36:39 +0600 [thread overview]
Message-ID: <200612220136.39905.litvinov2004@gmail.com> (raw)
In-Reply-To: <7vejqtaz7q.fsf@assigned-by-dhcp.cox.net>
> I do not think we want to change the commit header
Can you please explain why not ?
> (1) git-am should default to -u; this was suggested on the list
> long time ago, but is an incompatible change. v1.5.0 we
> can afford to be incompatible to make it more usable and
> safer.
I use git-am rarely so can't comment on this
> (2) update commit-tree to reject non utf-8 log messages and
> author/committer names when i18n.commitEncoding is _NOT_
> set, or set to utf-8.
>
> Maybe later we can use encoding validation routines for
> other encodings by checking i18n.commitEncoding, but at the
> minimum the above would be safe enough for recommended UTF-8
> only cases.
See the situation:
1. I have utf-8 encoded repo.
2. Somebody clone my repo, try to commit using non-utf-8 encoding, fail and
change i18n.commitEncoding. When it commits something and ask me to pull.
3. I pull and got non-utf-8 commit message :-)
next prev parent reply other threads:[~2006-12-21 19:36 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-08 11:44 [PATCH] Fix documentation copy&paste typo Uwe Kleine-Koenig
2006-12-19 14:16 ` Uwe Kleine-König
2006-12-19 17:27 ` Junio C Hamano
2006-12-21 8:59 ` specify charset for commits (Was: [PATCH] Fix documentation copy&paste typo) Uwe Kleine-König
2006-12-21 9:51 ` Johannes Schindelin
2006-12-21 10:11 ` Santi Béjar
2006-12-21 10:23 ` Alexander Litvinov
2006-12-21 10:52 ` Jakub Narebski
2006-12-21 13:05 ` Alexander Litvinov
2006-12-21 13:14 ` Jakub Narebski
2006-12-21 13:43 ` Uwe Kleine-König
2006-12-21 18:19 ` specify charset for commits Junio C Hamano
2006-12-21 18:48 ` Nicolas Pitre
2006-12-21 19:11 ` Uwe Kleine-König
2006-12-21 19:36 ` Alexander Litvinov [this message]
2006-12-22 12:07 ` Johannes Schindelin
2006-12-22 15:09 ` Uwe Kleine-König
2006-12-22 22:02 ` Uwe Kleine-König
2006-12-22 15:31 ` Nicolas Pitre
2006-12-22 19:01 ` Junio C Hamano
2006-12-22 21:03 ` [PATCH 1/2] libgit.a: add some UTF-8 handling functions Johannes Schindelin
2006-12-22 21:27 ` Junio C Hamano
2006-12-22 21:36 ` Johannes Schindelin
2006-12-22 21:58 ` Junio C Hamano
2006-12-22 22:20 ` Johannes Schindelin
2006-12-22 22:33 ` Junio C Hamano
2006-12-25 4:03 ` Alexander Litvinov
2006-12-22 22:14 ` Uwe Kleine-König
2006-12-22 22:19 ` Uwe Kleine-König
2006-12-22 22:34 ` Johannes Schindelin
2006-12-22 23:50 ` Johannes Schindelin
2006-12-23 8:52 ` Uwe Kleine-König
2006-12-23 14:12 ` Johannes Schindelin
2006-12-23 19:53 ` warn non utf-8 commit log messages Junio C Hamano
2006-12-23 23:46 ` Johannes Schindelin
2006-12-22 21:06 ` [PATCH 2/2] git-commit-tree: if i18n.commitencoding is utf-8 (default), check it Johannes Schindelin
2006-12-22 21:50 ` Junio C Hamano
2006-12-22 22:21 ` Johannes Schindelin
2006-12-22 21:15 ` [RFC/PATCH 3/2] Wrap lines in shortlog Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200612220136.39905.litvinov2004@gmail.com \
--to=litvinov2004@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=zeisberg@informatik.uni-freiburg.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.