Re: [patch 2.6.20-rc1 6/6] input: ads7846 directly senses PENUP state

[David Brownell <david-b@pacbell.net>]

On Friday 22 December 2006 12:35 pm, Dmitry Torokhov wrote:
> On 12/22/06, David Brownell <david-b@pacbell.net> wrote:
> >
> > +static void ads7846_report_pen_state(struct ads7846 *ts, int down)
> > +{
> > +       struct input_dev        *input_dev = ts->input;
> > +
> > +       input_report_key(input_dev, BTN_TOUCH, down);
> > +       if (!down)
> > +               input_report_abs(input_dev, ABS_PRESSURE, 0);
> > +#ifdef VERBOSE
> > +       pr_debug("%s: %s\n", ts->spi->dev.bus_id, down ? "DOWN" : "UP");
> > +#endif
> > +}
> > +
> > +static void ads7846_report_pen_position(struct ads7846 *ts, int x, int y,
> > +                                       int pressure)
> > +{
> > +       struct input_dev        *input_dev = ts->input;
> > +
> > +       input_report_abs(input_dev, ABS_X, x);
> > +       input_report_abs(input_dev, ABS_Y, y);
> > +       input_report_abs(input_dev, ABS_PRESSURE, pressure);
> > +
> > +#ifdef VERBOSE
> > +       pr_debug("%s: %d/%d/%d\n", ts->spi->dev.bus_id, x, y, pressure);
> > +#endif
> > +}
> > +
> > +static void ads7846_sync_events(struct ads7846 *ts)
> > +{
> > +       struct input_dev        *input_dev = ts->input;
> > +
> > +       input_sync(input_dev);
> > +}
> 
> I think these helpers just obfuscate the code, just call
> input_report_*() and input_sync() drectly like you used to do.

Fair enough, I had a similar thought.  Imre, could you do that update?


> 
> -- 
> Dmitry
>