From: Shawn Pearce <spearce@spearce.org>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 0/17] Sliding window mmap for packfiles.
Date: Sat, 23 Dec 2006 04:42:49 -0500 [thread overview]
Message-ID: <20061223094249.GC9396@spearce.org> (raw)
In-Reply-To: <7vlkkzrm0w.fsf@assigned-by-dhcp.cox.net>
Junio C Hamano <junkio@cox.net> wrote:
> I have to say i am very much impressed (I've taken a look at
> only the first half up to #11, though). How much has this been
> used in real projects?
None yet. I just finished remerging it onto current git.git code.
> A couple of comments:
>
> [3/17]
>
> I think losing "p->next = NULL" does not matter with the callers
> we have right now, but somehow this part makes me feel uneasy.
That's a bug in that patch. I removed it by mistake. Good catch.
> [5/17]
>
> I think it makes sense to exit(0) for the existing write_or_die
> upon EPIPE because that indicates we are the upstream of the
> pipe and the reading process has exit (i.e. user said 'q' to
> less while we still have more to say).
>
> I suspect the symmetry would not hold for read_or_die; when we
> are reading, EPIPE is not any different from any other errors
> (except for EAGAIN or EINTR which we already take care of in
> xread()) and the net effect is that we could not read what we
> wanted to.
Oh, good point.
--
Shawn.
next prev parent reply other threads:[~2006-12-23 9:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-23 7:33 [PATCH 0/17] Sliding window mmap for packfiles Shawn O. Pearce
2006-12-23 9:37 ` Junio C Hamano
2006-12-23 9:42 ` Shawn Pearce [this message]
2006-12-24 8:56 ` Francis Moreau
2006-12-24 9:05 ` Shawn Pearce
2006-12-24 9:36 ` Francis Moreau
2006-12-24 9:49 ` Shawn Pearce
2007-01-02 15:28 ` Andy Whitcroft
2006-12-24 9:29 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061223094249.GC9396@spearce.org \
--to=spearce@spearce.org \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.