All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Andrew Morton <akpm@osdl.org>,
	Jeremy Fitzhardinge <jeremy@goop.org>,
	Linus Torvalds <torvalds@osdl.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [patch] change WARN_ON back to "BUG: at ..."
Date: Sat, 23 Dec 2006 12:03:50 +0100	[thread overview]
Message-ID: <20061223110350.GA25279@elte.hu> (raw)
In-Reply-To: <1166839610.1573.20.camel@localhost.localdomain>


* Steven Rostedt <rostedt@goodmis.org> wrote:

> WARN_ON is still a BUG, but we know enough about it that we can just 
> cripple the system so that it doesn't break anything. [...]

well - a WARN_ON() can be /anything/. It is the same as BUG_ON(), but it 
doesnt crash the box immediately and on purpose. In that sense all 
existing BUG_ON()s should be converted to WARN_ON()s or to panic()s 
(whichever fits best for that particular BUG_ON()).

[ or all WARN_ON()s should be converted to BUG_ON()s and the behavior of
  BUG_ON() should be changed to /not/ crash the system on purpose - and
  for those cases where we really do not want to continue, panic()
  should be used. That way the user can set panic policy himself. ]

i can whip up a patch for any of these conversions, but i dont think we 
need this flux right now.

	Ingo

  reply	other threads:[~2006-12-23 11:06 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-21 12:43 [patch] change WARN_ON back to "BUG: at ..." Ingo Molnar
2006-12-21 13:00 ` Arjan van de Ven
2006-12-21 18:49 ` Jeremy Fitzhardinge
2006-12-21 23:57   ` Ingo Molnar
2006-12-22 20:04     ` Andrew Morton
2006-12-23  2:06       ` Steven Rostedt
2006-12-23 11:03         ` Ingo Molnar [this message]
2006-12-23 12:44           ` Steven Rostedt
2006-12-24 14:16       ` Pavel Machek
2006-12-28  9:15         ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061223110350.GA25279@elte.hu \
    --to=mingo@elte.hu \
    --cc=akpm@osdl.org \
    --cc=jeremy@goop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.