From: Al Viro <viro@ftp.linux.org.uk>
To: Christoph Hellwig <hch@infradead.org>
Cc: "Amit S. Kale" <amitkale@netxen.com>,
netdev@vger.kernel.org, brazilnut@us.ibm.com, jeff@garzik.org,
netxenproj@linsyssoft.com, rob@netxen.com, sanjeev@netxen.com,
wendyx@us.ibm.com
Subject: Re: [PATCH 7/8] NetXen: Fix for PPC machines.
Date: Wed, 27 Dec 2006 08:06:33 +0000 [thread overview]
Message-ID: <20061227080633.GN17561@ftp.linux.org.uk> (raw)
In-Reply-To: <20061227075854.GA32567@infradead.org>
On Wed, Dec 27, 2006 at 07:58:54AM +0000, Christoph Hellwig wrote:
> On Mon, Dec 18, 2006 at 05:53:59AM -0800, Amit S. Kale wrote:
> > Signed-off-by: Amit S. Kale <amitkale@netxen.com>
> >
> > netxen_nic.h | 2 +-
> > netxen_nic_init.c | 12 ++++++------
> > netxen_nic_main.c | 4 ++--
> > 3 files changed, 9 insertions(+), 9 deletions(-)
>
> Please use __le* types for all hardware data structures and use sparse
> to verify all your endianess handling is correct.
I have preliminary endianness annotations for that puppy; FWIW, a part of
it consists of _removing_ __le. Folks, readl() returns host-endian and
writel() takes host-endian as argument. They do conversions themselves.
One needs fixed-endian types in data structures shared with device - i.e.
anything in ioremapped area or dma'd to/from device.
prev parent reply other threads:[~2006-12-27 8:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-18 13:53 [PATCH 7/8] NetXen: Fix for PPC machines Amit S. Kale
2006-12-26 21:49 ` Jeff Garzik
2006-12-27 5:46 ` Amit Kale
2006-12-27 7:58 ` Christoph Hellwig
2006-12-27 8:06 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061227080633.GN17561@ftp.linux.org.uk \
--to=viro@ftp.linux.org.uk \
--cc=amitkale@netxen.com \
--cc=brazilnut@us.ibm.com \
--cc=hch@infradead.org \
--cc=jeff@garzik.org \
--cc=netdev@vger.kernel.org \
--cc=netxenproj@linsyssoft.com \
--cc=rob@netxen.com \
--cc=sanjeev@netxen.com \
--cc=wendyx@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.