From: Al Viro <viro@ftp.linux.org.uk>
To: Horms <horms@verge.net.au>
Cc: linux-kernel@vger.kernel.org, trivial@kernel.org
Subject: Re: [patch] linux/preempt.h needs linux/thread_info.h
Date: Wed, 27 Dec 2006 08:27:02 +0000 [thread overview]
Message-ID: <20061227082702.GO17561@ftp.linux.org.uk> (raw)
In-Reply-To: <20061227081701.GA19379@verge.net.au>
On Wed, Dec 27, 2006 at 05:17:02PM +0900, Horms wrote:
> It seems that linux/preempt.h needs to include linux/thread_info.h
> in order to access current_thread_info(), which is used in
> preempt_count().
>
> I guess that all callers of preempt_count() must include
> both linux/thread_info.h and linux/preempt.h directly or indirectly,
> as this does not cause a compile error. I noticed the problem while
> working on an unrelated issue in xen-land.
>
> Signed-off-by: Simon Horman <horms@verge.net.au>
>
> Index: linux-2.6/include/linux/preempt.h
> ===================================================================
> --- linux-2.6.orig/include/linux/preempt.h 2006-12-27 16:58:46.000000000 +0900
> +++ linux-2.6/include/linux/preempt.h 2006-12-27 17:13:12.000000000 +0900
> @@ -8,6 +8,7 @@
>
> #include <linux/thread_info.h>
> #include <linux/linkage.h>
> +#include <linux/thread_info.h>
Huh? It's just been included two lines above...
next prev parent reply other threads:[~2006-12-27 8:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-27 8:17 [patch] linux/preempt.h needs linux/thread_info.h Horms
2006-12-27 8:27 ` Al Viro [this message]
2006-12-27 9:07 ` Horms
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061227082702.GO17561@ftp.linux.org.uk \
--to=viro@ftp.linux.org.uk \
--cc=horms@verge.net.au \
--cc=linux-kernel@vger.kernel.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.