From: Ingo Molnar <mingo@elte.hu>
To: linux-kernel@vger.kernel.org
Cc: Andrew Morton <akpm@osdl.org>, Jens Axboe <axboe@suse.de>
Subject: Re: [patch] block: remove BKL dependency from drivers/block/loop.c
Date: Wed, 27 Dec 2006 16:47:13 +0100 [thread overview]
Message-ID: <20061227154713.GA4036@elte.hu> (raw)
In-Reply-To: <20061227115207.GA20721@elte.hu>
* Ingo Molnar <mingo@elte.hu> wrote:
> Subject: [patch] block: remove BKL dependency from drivers/block/loop.c
> From: Ingo Molnar <mingo@elte.hu>
>
> the block loopback device is protected by lo->lo_ctl_mutex and it does
> not need to hold the BKL anywhere. Convert its ioctl to unlocked_ioctl
> and remove the BKL acquire/release from its compat_ioctl.
hm, i must have messed up this bit:
> +static long lo_ioctl(struct file * file, unsigned int cmd, unsigned long arg)
> {
> + struct inode *inode = file->f_path.dentry->d_inode;
> struct loop_device *lo = inode->i_bdev->bd_disk->private_data;
because it now crashes there ... so forget this patch for now.
Ingo
next prev parent reply other threads:[~2006-12-27 15:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-27 11:52 [patch] block: remove BKL dependency from drivers/block/loop.c Ingo Molnar
2006-12-27 15:47 ` Ingo Molnar [this message]
2007-01-03 7:32 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061227154713.GA4036@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@osdl.org \
--cc=axboe@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.