From: Paul Mundt <lethal@linux-sh.org>
To: linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] Sanely size hash tables when using large base pages.
Date: Thu, 28 Dec 2006 09:29:34 +0900 [thread overview]
Message-ID: <20061228002934.GA18755@linux-sh.org> (raw)
In-Reply-To: <20061226074257.GA5853@mail.ustc.edu.cn>
On Tue, Dec 26, 2006 at 03:42:57PM +0800, Fengguang Wu wrote:
> On Tue, Dec 26, 2006 at 03:16:52PM +0900, Paul Mundt wrote:
> > pidhash_shift = max(4, fls(megabytes * 4));
> > pidhash_shift = min(12, pidhash_shift);
> > pidhash_size = 1 << pidhash_shift;
> >
> > + size = pidhash_size * sizeof(struct hlist_head);
> > + if (unlikely(size < PAGE_SIZE)) {
> > + size = PAGE_SIZE;
> > + pidhash_size = size / sizeof(struct hlist_head);
> > + pidhash_shift = 0;
>
> But pidhash_shift is not the order of page ;-)
>
Ah, you're right. I'll drop the pidhash changes and resubmit. Thanks.
WARNING: multiple messages have this Message-ID (diff)
From: Paul Mundt <lethal@linux-sh.org>
To: linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] Sanely size hash tables when using large base pages.
Date: Thu, 28 Dec 2006 09:29:34 +0900 [thread overview]
Message-ID: <20061228002934.GA18755@linux-sh.org> (raw)
In-Reply-To: <20061226074257.GA5853@mail.ustc.edu.cn>
On Tue, Dec 26, 2006 at 03:42:57PM +0800, Fengguang Wu wrote:
> On Tue, Dec 26, 2006 at 03:16:52PM +0900, Paul Mundt wrote:
> > pidhash_shift = max(4, fls(megabytes * 4));
> > pidhash_shift = min(12, pidhash_shift);
> > pidhash_size = 1 << pidhash_shift;
> >
> > + size = pidhash_size * sizeof(struct hlist_head);
> > + if (unlikely(size < PAGE_SIZE)) {
> > + size = PAGE_SIZE;
> > + pidhash_size = size / sizeof(struct hlist_head);
> > + pidhash_shift = 0;
>
> But pidhash_shift is not the order of page ;-)
>
Ah, you're right. I'll drop the pidhash changes and resubmit. Thanks.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2006-12-28 0:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-26 6:16 [PATCH] Sanely size hash tables when using large base pages Paul Mundt
2006-12-26 6:16 ` Paul Mundt
2006-12-26 7:42 ` Fengguang Wu
2006-12-26 7:42 ` Fengguang Wu
2006-12-26 7:42 ` Fengguang Wu
2006-12-28 0:29 ` Paul Mundt [this message]
2006-12-28 0:29 ` Paul Mundt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061228002934.GA18755@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.