From: Dave Jones <davej@redhat.com>
To: "Robert P. J. Day" <rpjday@mindspring.com>
Cc: Arjan van de Ven <arjan@infradead.org>,
Folkert van Heusden <folkert@vanheusden.com>,
Paul Mundt <lethal@linux-sh.org>,
Denis Vlasenko <vda.linux@googlemail.com>,
Linux kernel mailing list <linux-kernel@vger.kernel.org>
Subject: Re: replace "memset(...,0,PAGE_SIZE)" calls with "clear_page()"?
Date: Mon, 1 Jan 2007 14:05:38 -0500 [thread overview]
Message-ID: <20070101190538.GA20443@redhat.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0701010515560.6039@localhost.localdomain>
On Mon, Jan 01, 2007 at 05:27:10AM -0500, Robert P. J. Day wrote:
> > both look good... I'd be in favor of this. Maybe also add a part
> > about using GFP_KERNEL whenever possible, GFP_NOFS from filesystem
> > writeout code and GFP_NOIO from block writeout code (and never doing
> > in_interrupt()?GFP_ATOMIC:GFP_KERNEL !)
>
> it strikes me that that latter part is starting to go beyond the scope
> of simple coding style aesthetics and getting into actual coding
> distinctions. would that really be appropriate for the CodingStyle
> doc? i'm just asking.
Adding a separate 'good practices' doc wouldn't be a bad idea.
Dave
--
http://www.codemonkey.org.uk
next prev parent reply other threads:[~2007-01-01 19:06 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-29 6:16 replace "memset(...,0,PAGE_SIZE)" calls with "clear_page()"? Robert P. J. Day
2006-12-30 20:49 ` Denis Vlasenko
2006-12-30 22:08 ` Robert P. J. Day
2006-12-30 22:40 ` Denis Vlasenko
2007-01-03 6:23 ` dean gaudet
2006-12-30 22:45 ` Arjan van de Ven
2006-12-30 23:04 ` Robert P. J. Day
2006-12-31 18:39 ` Paul Mundt
2006-12-31 19:04 ` Robert P. J. Day
2007-01-01 1:59 ` Folkert van Heusden
2007-01-01 8:33 ` Robert P. J. Day
2007-01-01 10:14 ` Arjan van de Ven
2007-01-01 10:27 ` Robert P. J. Day
2007-01-01 19:05 ` Dave Jones [this message]
2007-01-01 8:42 ` Paul Mundt
2007-01-01 17:09 ` Randy Dunlap
2006-12-31 13:39 ` Folkert van Heusden
2006-12-31 13:45 ` Arjan van de Ven
2006-12-31 16:39 ` Robert P. J. Day
2006-12-31 17:43 ` Arjan van de Ven
2007-01-03 13:20 ` Robert P. J. Day
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070101190538.GA20443@redhat.com \
--to=davej@redhat.com \
--cc=arjan@infradead.org \
--cc=folkert@vanheusden.com \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rpjday@mindspring.com \
--cc=vda.linux@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.