From: "Shawn O. Pearce" <spearce@spearce.org>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org
Subject: Re: [RFC/PATCH] fail pull/merge early in the middle of conflicted merge
Date: Mon, 1 Jan 2007 15:43:54 -0500 [thread overview]
Message-ID: <20070101204354.GA26687@spearce.org> (raw)
In-Reply-To: <7vwt478b5d.fsf@assigned-by-dhcp.cox.net>
Junio C Hamano <junkio@cox.net> wrote:
> After a pull that results in a conflicted merge, a new user
> often tries another "git pull" in desperation. When the index
> is unmerged, merge backends correctly bail out without touching
> either index nor the working tree, so this does not make the
> wound any worse.
I've seen this many times too. I don't understand why users cannot
read output messages and realize the current command failed, but
they don't. *sigh*
> Old timers may know better and would not to try pulling again
> before cleaning things up; this change adds extra overhead that
> is unnecessary for them. But this would be worth paying for to
> save new people from needless confusion.
This penalty isn't very high though; its just a single pass through
the index to look for an unmerged entry. I think that small
penalty is worth the better error message here, and that's the guy
who just submitted patches to remove other penalties in pull and
merge talking. :-)
--
Shawn.
next prev parent reply other threads:[~2007-01-01 20:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-01 7:21 [RFC/PATCH] fail pull/merge early in the middle of conflicted merge Junio C Hamano
2007-01-01 20:43 ` Shawn O. Pearce [this message]
2007-01-02 19:35 ` Junio C Hamano
2007-01-04 15:37 ` Andreas Ericsson
2007-01-04 16:31 ` Horst H. von Brand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070101204354.GA26687@spearce.org \
--to=spearce@spearce.org \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.