Re: PATCH: SNI RM 53c710 driver

[Christoph Hellwig <hch@infradead.org>]

On Mon, Dec 25, 2006 at 09:32:04PM +0100, Thomas Bogendoerfer wrote:
> This patch adds a SCSI driver for the onboard 53c710 chip of some
> SNI RM machines.

Nice, this looks really clean.  I haven't seen the code to declare
the platform devices in the mips queue yet, do you plan to submit it
soon?

> +static int __init snirm710_init(void)
> +{
> +	int err;
> +	
> +	if ((err = platform_driver_register(&snirm710_driver))) {
> +		printk(KERN_ERR "Driver registration failed\n");
> +		return err;
> +	}
> +	return 0;
> +}

Please just write this as:

static int __init snirm710_init(void)
{
	return platform_driver_register(&snirm710_driver)));
}

In the modular case we already get a message from modprobe and in
the builtin-case verbose initcalls also display the error.