From: Christoph Hellwig <hch@infradead.org>
To: Ivo Van Doorn <ivdoorn@gmail.com>
Cc: Jan Kiszka <jan.kiszka@web.de>, Jiri Benc <jbenc@suse.cz>,
netdev@vger.kernel.org, rt2400-devel@lists.sourceforge.net
Subject: Re: [PATCH] d80211: Fix inconsistent sta_lock usage
Date: Tue, 2 Jan 2007 16:22:01 +0000 [thread overview]
Message-ID: <20070102162201.GA28457@infradead.org> (raw)
In-Reply-To: <a32f33a40701020730n773d7ed8pe99d98ecc7b96a0e@mail.gmail.com>
On Tue, Jan 02, 2007 at 04:30:41PM +0100, Ivo Van Doorn wrote:
> +static inline void __bss_tim_set(struct ieee80211_local *local,
> + struct ieee80211_if_ap *bss, int aid)
> +{
> + bss->tim[(aid)/8] |= 1<<((aid) % 8);
> +}
This really screams to be converted to __set_bit. Also the local
argument is entirely unused. I'd probaby not even add a helper for
this but just opencode it as:
__set_bit(&bss->time, aid);
> +static inline void __bss_tim_clear(struct ieee80211_local *local,
> + struct ieee80211_if_ap *bss, int aid)
> +{
> + bss->tim[(aid)/8] &= !(1<<((aid) % 8));
Similarly this should just be __clear_bit
next prev parent reply other threads:[~2007-01-02 16:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-01 20:19 [PATCH] d80211: Fix inconsistent sta_lock usage Jan Kiszka
2007-01-02 15:30 ` Ivo Van Doorn
2007-01-02 16:22 ` Christoph Hellwig [this message]
2007-01-05 20:08 ` Ivo van Doorn
2007-01-06 16:33 ` Jan Kiszka
2007-01-06 16:52 ` Johannes Berg
2007-01-06 16:59 ` Johannes Berg
2007-01-06 17:00 ` Jan Kiszka
2007-01-06 17:01 ` Johannes Berg
2007-01-06 19:09 ` Ivo Van Doorn
2007-01-10 20:13 ` Jiri Benc
2007-01-06 16:52 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070102162201.GA28457@infradead.org \
--to=hch@infradead.org \
--cc=ivdoorn@gmail.com \
--cc=jan.kiszka@web.de \
--cc=jbenc@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=rt2400-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.