All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo-X9Un+BFzKDI@public.gmane.org>
To: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
Cc: kvm-devel <kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
Subject: Re: [patch] kvm: make cr3 loading more robust
Date: Wed, 3 Jan 2007 13:28:14 +0100	[thread overview]
Message-ID: <20070103122814.GA7350@elte.hu> (raw)
In-Reply-To: <459BA0B4.20804-atKUWr5tajBWk0Htik3J/w@public.gmane.org>


* Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org> wrote:

> Note that the corner cases will never be 100% emulatable.  For 
> example, you can set cr3 to point at your IDE DMA mmio space or 
> something like that.  It's quite all right to kill the guest quietly 
> at that point, as no real-life guest will do that.

yes. Or to map the lapic to the IDT ;-) (as yours truly has tried it 
years ago)

that's why my suggestion is to just kill the guest. Loading such a cr3 
is a serious bug that might be hard to debug in the guest. I had to 
debug at least one such bug in Linux before (years ago, in the lazy TLB 
switching code) and it was a royal PITA to track down. Having a 
hypervisor that points any cr3 load error out /before/ the effects of 
the error propagate further is a bonus, not an incompatibility. The CPU 
does not implement this not because the semantics is important, but i 
suspect mostly because it doesnt really know the boundaries and type of 
RAM.

> The kvm goals do not include cycle accurate emulation. [...]

yes. That's why i'm suggesting to kill the VM in such a scenario. A cr3 
value is only valid if it points to real RAM.

	Ingo

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV

  parent reply	other threads:[~2007-01-03 12:28 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-03  2:10 [patch] kvm: make cr3 loading more robust Ingo Molnar
     [not found] ` <20070103021057.GA11316-X9Un+BFzKDI@public.gmane.org>
2007-01-03  8:29   ` Avi Kivity
     [not found]     ` <459B695C.5090004-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-01-03 11:52       ` Ingo Molnar
     [not found]         ` <20070103115230.GB937-X9Un+BFzKDI@public.gmane.org>
2007-01-03 12:00           ` Avi Kivity
     [not found]             ` <459B9AC7.6020506-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-01-03 12:01               ` Avi Kivity
2007-01-03 12:13               ` Ingo Molnar
     [not found]                 ` <20070103121301.GC2786-X9Un+BFzKDI@public.gmane.org>
2007-01-03 12:25                   ` Avi Kivity
     [not found]                     ` <459BA0B4.20804-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-01-03 12:28                       ` Ingo Molnar [this message]
     [not found]                         ` <20070103122814.GA7350-X9Un+BFzKDI@public.gmane.org>
2007-01-03 12:40                           ` Ingo Molnar
     [not found]                             ` <20070103124020.GA9738-X9Un+BFzKDI@public.gmane.org>
2007-01-03 13:14                               ` Avi Kivity
     [not found]                                 ` <459BAC45.9090202-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-01-03 13:20                                   ` Ingo Molnar
     [not found]                                     ` <20070103132033.GA18027-X9Un+BFzKDI@public.gmane.org>
2007-01-03 13:34                                       ` Avi Kivity
2007-01-03 12:59                           ` Avi Kivity
2007-01-03 11:59       ` Ingo Molnar
     [not found]         ` <20070103115911.GA2786-X9Un+BFzKDI@public.gmane.org>
2007-01-03 12:06           ` Avi Kivity
     [not found]             ` <459B9C5C.9060008-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-01-03 12:21               ` Ingo Molnar
     [not found]                 ` <20070103122114.GD2786-X9Un+BFzKDI@public.gmane.org>
2007-01-03 12:29                   ` Avi Kivity
     [not found]                     ` <459BA194.8070305-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-01-03 12:32                       ` Ingo Molnar
     [not found]                         ` <20070103123253.GA8822-X9Un+BFzKDI@public.gmane.org>
2007-01-03 13:13                           ` Avi Kivity
2007-01-03 13:37                           ` Ingo Molnar
     [not found]                             ` <20070103133714.GA20638-X9Un+BFzKDI@public.gmane.org>
2007-01-03 13:44                               ` Ingo Molnar
     [not found]                                 ` <20070103134417.GA22055-X9Un+BFzKDI@public.gmane.org>
2007-01-04  8:58                                   ` Avi Kivity
     [not found]                                     ` <459CC1BC.3070308-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-01-04  9:06                                       ` Ingo Molnar
2007-01-04  8:55                               ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070103122814.GA7350@elte.hu \
    --to=mingo-x9un+bfzkdi@public.gmane.org \
    --cc=avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org \
    --cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.