From: Alan <alan@lxorguk.ukuu.org.uk>
To: ahendry <ahendry@tusc.com.au>
Cc: linux-x25@vger.kernel.org, eis@baty.hanse.de,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 2.6.19 1/2] X.25: Adds call forwarding to X.25
Date: Thu, 4 Jan 2007 10:27:02 +0000 [thread overview]
Message-ID: <20070104102702.30630a9d@localhost.localdomain> (raw)
In-Reply-To: <1167881822.5124.88.camel@localhost>
> + struct sk_buff *skbn;
> + skbn = skb_clone(skb, GFP_ATOMIC);
> +
If this fails then you starting passing NULL around. I'm also a bit
confused as to where you free the copy in all the error cases ?
Is there any reason for creating skbn here rather than in
skb_forward_call ?
next prev parent reply other threads:[~2007-01-04 10:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-04 3:37 [PATCH 2.6.19 1/2] X.25: Adds call forwarding to X.25 ahendry
2007-01-04 10:27 ` Alan [this message]
2007-02-07 23:14 ` [PATCH 1/3] [RESEND] X.25: Add call forwarding ahendry
2007-02-08 21:34 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070104102702.30630a9d@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=ahendry@tusc.com.au \
--cc=eis@baty.hanse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-x25@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.